From owner-freebsd-current Wed May 29 13:29:12 2002 Delivered-To: freebsd-current@freebsd.org Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by hub.freebsd.org (Postfix) with ESMTP id D590337B42B; Wed, 29 May 2002 13:28:50 -0700 (PDT) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.3/8.12.2) with ESMTP id g4TKRcKu013193; Wed, 29 May 2002 22:27:38 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: Matthew Dillon Cc: "David O'Brien" , Julian Elischer , John Baldwin , FreeBSD current users Subject: Re: Seeking OK to commit KSE MIII In-Reply-To: Your message of "Wed, 29 May 2002 13:07:01 PDT." <200205292007.g4TK71YD062671@apollo.backplane.com> Date: Wed, 29 May 2002 22:27:38 +0200 Message-ID: <13192.1022704058@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <200205292007.g4TK71YD062671@apollo.backplane.com>, Matthew Dillon w rites: > I agree that as a general rule of thumb it makes sense to commit > whitespace/paren/brace changes separately, but that is ALL it is. > A rule of thumb. It should not be followed blindly, on principle, > if it has an adverse effect on the developer tring to do the work, > and it certainly should not be made a prerequisit for having good > work comitted. I see no benefit to the project or the developer > community. For complex patches, which should get good and thorough reviews before they are committed, avoiding unsubstantial style/whitespace changes from cluttering the patch should be mandatory. Julians patch clearly belongs in this category. Consequently, it is in Julians own interest to get the whitespace/style changes into the tree first (they don't need a review, if he does them right) since that makes the patch people have to read through correspondingly smaller. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message