From owner-svn-src-all@FreeBSD.ORG Thu Jul 23 18:38:55 2009 Return-Path: <owner-svn-src-all@FreeBSD.ORG> Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5DF06106566B; Thu, 23 Jul 2009 18:38:55 +0000 (UTC) (envelope-from jh@saunalahti.fi) Received: from gw03.mail.saunalahti.fi (gw03.mail.saunalahti.fi [195.197.172.111]) by mx1.freebsd.org (Postfix) with ESMTP id 199C88FC1B; Thu, 23 Jul 2009 18:38:55 +0000 (UTC) (envelope-from jh@saunalahti.fi) Received: from a91-153-125-115.elisa-laajakaista.fi (a91-153-125-115.elisa-laajakaista.fi [91.153.125.115]) by gw03.mail.saunalahti.fi (Postfix) with SMTP id B76EA216617; Thu, 23 Jul 2009 21:38:49 +0300 (EEST) Date: Thu, 23 Jul 2009 21:38:49 +0300 From: Jaakko Heinonen <jh@saunalahti.fi> To: John Baldwin <jhb@freebsd.org> Message-ID: <20090723183849.GB3773@a91-153-125-115.elisa-laajakaista.fi> References: <200907141945.n6EJjaMC069356@svn.freebsd.org> <20090723103014.GA2316@a91-153-125-115.elisa-laajakaista.fi> <200907230845.21147.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200907230845.21147.jhb@freebsd.org> User-Agent: Mutt/1.5.19 (2009-01-05) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r195693 - in head: lib/libc/sys sys/vm X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" <svn-src-all.freebsd.org> List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>, <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all> List-Post: <mailto:svn-src-all@freebsd.org> List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help> List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>, <mailto:svn-src-all-request@freebsd.org?subject=subscribe> X-List-Received-Date: Thu, 23 Jul 2009 18:38:55 -0000 On 2009-07-23, John Baldwin wrote: > > After this change locate(1) gives an obscure error message for empty > > database files. > > Ah, odd. Perhaps it would be best to just move the original "too > small" check earlier: Looks good to me except you should use "db" instead of "database" in search_mmap(). > + if (len < (2*NBG)) > + errx(1, "database too small: %s", database); Thanks. -- Jaakko