From owner-freebsd-bugs@FreeBSD.ORG Thu Aug 5 19:00:47 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E917116A4CE for ; Thu, 5 Aug 2004 19:00:47 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id DE4A543D48 for ; Thu, 5 Aug 2004 19:00:47 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id i75J0l1E060843 for ; Thu, 5 Aug 2004 19:00:47 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i75J0l3n060840; Thu, 5 Aug 2004 19:00:47 GMT (envelope-from gnats) Date: Thu, 5 Aug 2004 19:00:47 GMT Message-Id: <200408051900.i75J0l3n060840@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Ian Dowse Subject: Re: kern/67455: EHCI controller is being programmed with incorrect address during ehci_open ( ehci.c) X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Ian Dowse List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Aug 2004 19:00:48 -0000 The following reply was made to PR kern/67455; it has been noted by GNATS. From: Ian Dowse To: rajesh mittal Cc: bug-followup@FreeBSD.org Subject: Re: kern/67455: EHCI controller is being programmed with incorrect address during ehci_open ( ehci.c) Date: Thu, 05 Aug 2004 19:58:23 +0100 In message <200408051830.i75IUboH059169@freefall.freebsd.org>, rajesh mittal wr ites: >The following reply was made to PR kern/67455; it has been noted by GNATS. > > Referring to EHCI 1.0 spec. On page 48 is > Sitd definition not QH. Please look at page 58 and you > will see QH definition Endpoint Description register > in Table 3-19. Bits 11:8 are Endpoint number > bits(address). So Endpoint number is really 4 bit > wide. > It seems that this issue is result of typo in the code > as UE_GET_ADDR(x) macro is already defined in the code > and used in other places. > Please let me know if you need any other information. Hi, I think you are correct here, although this seems to have been fixed already in revision 1.7 of ehci.c (June 26th). Can you confirm that this is the case and the PR can be closed? Ian