From owner-freebsd-stable Wed Apr 18 12: 1:19 2001 Delivered-To: freebsd-stable@freebsd.org Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by hub.freebsd.org (Postfix) with ESMTP id 8382B37B423; Wed, 18 Apr 2001 12:01:14 -0700 (PDT) (envelope-from phk@critter.freebsd.dk) Received: from critter (localhost [127.0.0.1]) by critter.freebsd.dk (8.11.3/8.11.3) with ESMTP id f3IJ0wU42562; Wed, 18 Apr 2001 21:00:58 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: obrien@FreeBSD.ORG Cc: Jordan Hubbard , freebsd-stable@FreeBSD.ORG, nicholas harteau , netch@netch.kiev.ua Subject: Re: Fw: fresh 4.3-RC: "microuptime went backwards", console lockup In-Reply-To: Your message of "Wed, 18 Apr 2001 11:15:25 PDT." <20010418111525.B22207@dragon.nuxi.com> Date: Wed, 18 Apr 2001 21:00:58 +0200 Message-ID: <42560.987620458@critter> From: Poul-Henning Kamp Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG I belive the correct value is ~0u, the 0x1ffff was a mistake and I'm pretty sure it is fixed in a subsequent commit. In message <20010418111525.B22207@dragon.nuxi.com>, "David O'Brien" writes: >On Wed, Apr 18, 2001 at 09:14:25AM -0700, Jordan Hubbard wrote: >> Erm, I'd really like your opinion on this. The guy is feeling >> naturally somewhat slighted. > >Very sorry about missing this. > >> MFC: >> Convert all users of fldoff() to offsetof(). fldoff() is bad >> because it only takes a struct tag which makes it impossible to >> use unions, typedefs etc. >... >> === cut === >> --- src/sys/i386/isa/clock.c 2000/08/03 00:09:29 1.149.2.1 >> +++ src/sys/i386/isa/clock.c 2001/03/05 13:09:01 1.149.2.2 >> [...skipped by netch...] >> @@ -191,7 +191,7 @@ SYSCTL_OPAQUE(_debug, OID_AUTO, tsc_time >> static struct timecounter i8254_timecounter = { >> i8254_get_timecount, /* get_timecount */ >> 0, /* no poll_pps */ >> - ~0u, /* counter_mask */ >> + 0x1ffff, /* counter_mask */ >> 0, /* frequency */ >> "i8254" /* name */ >> }; >> === end cut === >> >> and contains no more, hence commit description is _totally bogus_. > >The commit message is the same as the clock.c rev 1.162 change which was >part of PHK's commit I was MFC'ing (I was using a script to pipe commit >emails thru to produce the diffs). > >I do not know if this change in the original commit by PHK was an >accident, or somewhere else in the system something is different from >RELENG_4 such that it needs a different value in the struct. > >Maybe PHK can comment on that part of the change. > >I certainly do not mind backing out clock.c rev 1.149.2.2 if you want. > >-- >-- David (obrien@FreeBSD.org) > -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message