Date: Mon, 9 Jul 2018 08:43:47 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: Sean Chittenden <seanc@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r473756 - head/security/teleport Message-ID: <20180709064347.cjcoqtj2vtqu64uv@atuin.in.mat.cc> In-Reply-To: <20180702192120.bmrv74c4atutx26b@atuin.in.mat.cc> References: <201807021659.w62GxDgI031531@repo.freebsd.org> <20180702192120.bmrv74c4atutx26b@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
--dhcumaz5llrzvyas Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 02, 2018 at 09:21:20PM +0200, Mathieu Arnold wrote: > On Mon, Jul 02, 2018 at 04:59:13PM +0000, Sean Chittenden wrote: > > Author: seanc > > Date: Mon Jul 2 16:59:13 2018 > > New Revision: 473756 > > URL: https://svnweb.freebsd.org/changeset/ports/473756 > >=20 > > Log: > > Optimize teleport build further and reuse the same sed invocation. > > =20 > > Submitted by: mat > > Approved by: mat (mentor, implicit) > > Pointy hat: seanc > >=20 > > Modified: > > head/security/teleport/Makefile > >=20 > > Modified: head/security/teleport/Makefile > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/security/teleport/Makefile Mon Jul 2 16:45:53 2018 (r473755) > > +++ head/security/teleport/Makefile Mon Jul 2 16:59:13 2018 (r473756) > > @@ -45,9 +45,9 @@ post-extract: > > post-patch: > > @${REINPLACE_CMD} -e 's|^GITREF=3D.*|GITREF=3D${GH_TAG_COMMIT}|' \ > > ${WRKDIR}/${GO_TELEPORT_SRC_DIR}/version.mk > > - @${FIND} ${WRKDIR} -type f \ > > - -exec ${SED} -i '' -e 's|\/var\/lib|/var/db|g' {} \; \ > > - -exec ${SED} -i '' -e 's|\/usr\/bin\/hostname|/bin/hostname|g' {} \; > > + @${FIND} ${WRKDIR} -type f -exec ${SED} -i '' \ > > + -e 's|\/var\/lib|/var/db|g' \ > > + -e 's|\/usr\/bin\/hostname|/bin/hostname|g' {} \; >=20 > Now, you are only running one sed for each file in WRKDIR instead of > two. Let's cut that down to only one sed call for all the files, please > replace "\;" with "+". Ping? --=20 Mathieu Arnold --dhcumaz5llrzvyas Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAltDBCNfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkg7hQ//RhDHXET2zMm1va29kd11JG49BMDHySQdDnL66UzEQMcKtDdiXwAuv45e MR3f5L2DPlJccqDBxIUvN3VfhimueyH5jUK52x9HuDDEbT0skEVFNPj0tzhmAOTo WWjP8BSHG3avn+FzwNjpRt//LmwzhSWdUypoY78KYtf1xnGrMmHenUgn+C+6FhTO EytrVHWKXYINlFjJeO9MbTahgrvLQxJyMQgjs8hAYcXYn76l8NO0xYfScCpyqZHx cGSkbJ3IBLTrabab4VlkhyMjtBZwr/JcZCNQs2dt20dSGRxx+sRNLWOzPAjoQeVZ hGS0zfu8tOoByZNyB2wnsHldlj6lSkKBbuhtmKh6T8GvQUU1sXBaA48sL9JvylDR b4r1osRAgPHvEQSms20uTfoGK0YArB3G25eglDZYijdS9+gq8kxhakv0OvU4MPPJ Y9KOsUPI4bNdeJ3h2oSO4P/SaoVd/+Da/4vOa8j/JtDp3x2pVrKbnNciF2NGui+S OHrMEHTwWkKJvpUUPWrmtYOvclsA2AXXKkzIARvyrUOnrXX2rXgBgnbB8Iwaqqgq TmBx9YDX1i5ElRnaDHI00/ztZl2iMz5lRXbIuMC3ndjJHBTN2A5rQfOHCsjVSSQH t9LMYHJZESWBcc/P78AqVvq4NX+2cguTIHf0DnETIoBMuVf6h0Y= =fwg5 -----END PGP SIGNATURE----- --dhcumaz5llrzvyas--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180709064347.cjcoqtj2vtqu64uv>