From owner-cvs-all@FreeBSD.ORG  Mon Mar 23 23:14:13 2009
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: by hub.freebsd.org (Postfix, from userid 664)
	id 19C991065673; Mon, 23 Mar 2009 23:14:13 +0000 (UTC)
Date: Mon, 23 Mar 2009 23:14:13 +0000
From: David O'Brien <obrien@FreeBSD.ORG>
To: Pav Lucistnik <pav@FreeBSD.org>
Message-ID: <20090323231412.GA94221@hub.freebsd.org>
References: <200903120954.n2C9s2ev063133@repoman.freebsd.org>
	<20090313023956.GA49511@dragon.NUXI.org>
	<49BA52D2.8090209@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <49BA52D2.8090209@FreeBSD.org>
User-Agent: Mutt/1.4.2.1i
X-Operating-System: FreeBSD 6.4-STABLE
Organization: The NUXI BSD group
X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3  90 76 5D 69 58 D9 98 7A
X-Pgp-Rsa-Keyid: 1024/34F9F9D5
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/shells/bash Makefile pkg-plist
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: obrien@freebsd.org
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Mar 2009 23:14:13 -0000

On Fri, Mar 13, 2009 at 01:34:26PM +0100, Pav Lucistnik wrote:
> David O'Brien wrote:
> >On Thu, Mar 12, 2009 at 09:54:01AM +0000, Sergey A. Osokin wrote:
> >>osa         2009-03-12 09:54:01 UTC
> >>  FreeBSD ports repository
> >>  Modified files:
> >>    shells/bash          Makefile pkg-plist 
> >>  Log:
> >>  Fix pkg-plist.
> >>  Bump PORTREVISION.
> >
> >Thanks for fixing the PLIST (much appreciated), but why did you bump
> >PORTREVISION for a PLIST change?
> >
> >There is zero reason to force a reinstall for a PLIST change.  Either the
> >port is already installed (and the user can wait for some other reason to
> >update), or the port isn't installed and bumping PORTREVISION does
> >nothing.
> 
> It's needed for package cluster, otherwise it does not know to rebuild 
> and will serve incomplete package forever.

Is there ever a change then that doesn't require a bump in either
PORTREVISION or PORTVERSION?

If not, maybe we should do away with PORTREVISION and use something like:

${PORTNAME}-${PORTVERSION}_${VCS_ID}

That way the revision # would automatically be bumped with every commit.

-- 
-- David    (obrien@FreeBSD.org)