From nobody Sun Feb 19 06:55:18 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PKGX03v9Jz3srTn for ; Sun, 19 Feb 2023 06:55:12 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PKGWz00mmz3lZM for ; Sun, 19 Feb 2023 06:55:11 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20210112.gappssmtp.com header.s=20210112 header.b="OqK0sID/"; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2a00:1450:4864:20::533) smtp.mailfrom=wlosh@bsdimp.com; dmarc=none Received: by mail-ed1-x533.google.com with SMTP id ee44so4661300edb.5 for ; Sat, 18 Feb 2023 22:55:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=g3393x33pM/U10tfVbf8ydifh8/64vJgr/olaNHmvQU=; b=OqK0sID/6cYNHXHHoJogJuQ6kAyqDOLhqQGGLtzcqXob16j6XDcX9x1RVItLm4SRTp 7rAFJi1U4Xfpxvgq5sOxBATyNERQnaiGfNUSF3e9Gbsvy9/gDqmymCmpWiXf2t4qMaJC pC5sSr2gpPCLC3bSiUkgTPlXesQ46xN8gnHjZBXdF+XSilu25Zq6XmkBMb7zck0OTuwj 3ca6u9+xOL04wofdcUSOKVOgBl+luasj0Rmzvhtk6e3fSnYG664E6+v9KgQVNbvCJlVQ Z2NzNpDQo9frJz5GsMN92E3BScMO+ynLI/4gFFI7y6Iwh/U00yK2Yysv6n3+3hEZi8bf LNoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=g3393x33pM/U10tfVbf8ydifh8/64vJgr/olaNHmvQU=; b=2pcl+fufZlfEZxj/+aI2DhCqkQHA6ATb2/xptD3oLuvyqgRtO7q0KY+xZOoFh4U61X DhstfkaDyohPgg38kJgZkNo4q1Lxw+oYcxAb6VrnEEMqEl/z1ESRa4IvVWUMiqgh6jBI s825mCXCZTJuz3eEjmt9ZdcoZQokNZPgWaeB0mL5mEBb+42eI5urDlcIg4FBChaaiW0s QsLYx6iPInDfg4P7w91l4M8BYf2d4PlBWD7bmMBHdW1m8HRPUFG+n3cVlT3aNrSby2Oc 5n4XBssjV8fxRakITteMRuDLGRonBkEQASBmcFDrfNDEtZ6Fwn6Np/KeeFytX18WLk8V 1zCg== X-Gm-Message-State: AO0yUKVeJ1Fl34Kt3Qz++ME/Yh3LpaUgXpl/EVC5076HOGeFECMyZ7Uk ew8wfykdqU9cAQxXPa2c6ReY71poveIUdGH0sjDFcw== X-Google-Smtp-Source: AK7set8fFuT0DgUoV0ZcqdiuJtrTb1xYLkHv9gny1ZTLqFK7sfQ+Dl6+oYEEmw0due6knWbgLGftWX9IOVLh1inDTsw= X-Received: by 2002:a50:9fa6:0:b0:4ad:72b2:cf57 with SMTP id c35-20020a509fa6000000b004ad72b2cf57mr873719edf.0.1676789708929; Sat, 18 Feb 2023 22:55:08 -0800 (PST) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 References: In-Reply-To: From: Warner Losh Date: Sat, 18 Feb 2023 23:55:18 -0700 Message-ID: Subject: Re: Build breakage with WITH_BEARSSL=1 To: Gordon Bergling Cc: FreeBSD Current Content-Type: multipart/alternative; boundary="000000000000f6d36105f50806c5" X-Spamd-Result: default: False [-3.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20210112.gappssmtp.com:s=20210112]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; ARC_NA(0.00)[]; MLMMJ_DEST(0.00)[freebsd-current@freebsd.org]; R_SPF_NA(0.00)[no SPF record]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::533:from]; DKIM_TRACE(0.00)[bsdimp-com.20210112.gappssmtp.com:+]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; DMARC_NA(0.00)[bsdimp.com]; TO_DN_ALL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Queue-Id: 4PKGWz00mmz3lZM X-Spamd-Bar: -- X-ThisMailContainsUnwantedMimeParts: N --000000000000f6d36105f50806c5 Content-Type: text/plain; charset="UTF-8" On Thu, Feb 16, 2023 at 12:57 AM Gordon Bergling wrote: > Hi Warner, > > On Wed, Feb 15, 2023 at 10:07:08AM -0700, Warner Losh wrote: > > On Sun, Feb 12, 2023, 3:18 PM Warner Losh wrote: > > > On Sun, Feb 12, 2023 at 3:54 AM Gordon Bergling > wrote: > > > > > >> Hi, > > >> > > >> I am currently seeing a build breakage when building -CURRENT with > > >> WITH_BEARSSL=1. > > >> > > >> The error is the following > > >> > > >> make[5]: "/boiler/nfs/src/lib/libsecureboot/local.trust.mk" line > 109: > > >> warning: "cd /boiler/nfs/src/lib/libsecureboot && 'ls' -1 *.pem > t*.asc 2> > > >> /dev/null" returned non-zero status > > >> /boiler/nfs/src/contrib/bearssl/src/rsa/rsa_i62_keygen.c:43:22: > error: > > >> a function declaration without a prototype is deprecat ed in all > versions > > >> of C [-Werror,-Wstrict-prototypes] > > >> br_rsa_i62_keygen_get() > > >> ^ > > >> void > > >> 1 error generated. > > >> --- rsa_i62_keygen.pico --- > > >> > > >> > > >> When disabling BEARSSL in the src.conf the build succeeds as usual. > > >> > > >> Has anyone also seen this build error. Sources are very recent and the > > >> src.conf is the following: > > >> > > >> WITH_EXTRA_TCP_STACKS=1 > > >> #WITH_BEARSSL=1 > > >> WITH_PIE=1 > > >> WITH_RETPOLINE=1 > > >> WITH_INIT_ALL_ZERO=1 > > >> WITH_OPENSSL_KTLS=1 > > >> WITHOUT_CLEAN=1 > > >> > > >> Any help is very appreciated. > > >> > > >> > > > What does the following do for you? It's a cut and pasted patch, but it > > > should be clear enough what to do if the mailer mangles it. > > > > > > diff --git a/lib/libbearssl/Makefile.inc b/lib/libbearssl/Makefile.inc > > > index dd0e242c8ef0..2af4864d8441 100644 > > > --- a/lib/libbearssl/Makefile.inc > > > +++ b/lib/libbearssl/Makefile.inc > > > @@ -4,4 +4,4 @@ BEARSSL?= ${SRCTOP}/contrib/bearssl > > > BEARSSL_SRC= ${BEARSSL}/src > > > > > > CFLAGS+= -I${BEARSSL}/inc > > > - > > > +CFLAGS+= ${NO_WDEPRECATED_NON_PROTOTYPE} > > > > > > > I went ahead and committed this. Please let me know if the problem > persists. > > Sorry for the late reply. I just tried a fresh build and it still fails > with > > [..]/src/contrib/bearssl/src/rsa/rsa_i62_keygen.c:43:22: error: a function > declaration without a prototype is deprecated in all versions of C > [-Werror,-Wstrict-prototypes] > br_rsa_i62_keygen_get() > > Did you see any other possibilty to fix this? > Oh, maybe add -Wno-strict-prototypes to where I added NO_WDEPRECATED_NON_PROTOTYPES? Warner --000000000000f6d36105f50806c5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Thu, Feb 16, 2023 at 12:57 AM Gord= on Bergling <gbe@freebsd.org> = wrote:
Hi Warner= ,

On Wed, Feb 15, 2023 at 10:07:08AM -0700, Warner Losh wrote:
> On Sun, Feb 12, 2023, 3:18 PM Warner Losh <imp@bsdimp.com> wrote:
> > On Sun, Feb 12, 2023 at 3:54 AM Gordon Bergling <gbe@freebsd.org> wrote:
> >
> >> Hi,
> >>
> >> I am currently seeing a build breakage when building -CURRENT= with
> >> WITH_BEARSSL=3D1.
> >>
> >> The error is the following
> >>
> >>=C2=A0 =C2=A0make[5]: "/boiler/nfs/src/lib/libsecureboot/= loca= l.trust.mk" line 109:
> >> warning: "cd /boiler/nfs/src/lib/libsecureboot &&= ; 'ls'=C2=A0 =C2=A0-1 *.pem t*.asc 2>
> >> /dev/null" returned non-zero status
> >>=C2=A0 =C2=A0/boiler/nfs/src/contrib/bearssl/src/rsa/rsa_i62_k= eygen.c:43:22: error:
> >> a function declaration without a prototype is deprecat=C2=A0 = ed in all versions
> >> of C [-Werror,-Wstrict-prototypes]
> >>=C2=A0 =C2=A0br_rsa_i62_keygen_get()
> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 ^
> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0void
> >>=C2=A0 =C2=A01 error generated.
> >>=C2=A0 =C2=A0--- rsa_i62_keygen.pico ---
> >>
> >>
> >> When disabling BEARSSL in the src.conf the build succeeds as = usual.
> >>
> >> Has anyone also seen this build error. Sources are very recen= t and the
> >> src.conf is the following:
> >>
> >> WITH_EXTRA_TCP_STACKS=3D1
> >> #WITH_BEARSSL=3D1
> >> WITH_PIE=3D1
> >> WITH_RETPOLINE=3D1
> >> WITH_INIT_ALL_ZERO=3D1
> >> WITH_OPENSSL_KTLS=3D1
> >> WITHOUT_CLEAN=3D1
> >>
> >> Any help is very appreciated.
> >>
> >>
> > What does the following do for you? It's a cut and pasted pat= ch, but it
> > should be clear enough what to do if the mailer mangles it.
> >
> > diff --git a/lib/libbearssl/Makefile.inc b/lib/libbearssl/Makefil= e.inc
> > index dd0e242c8ef0..2af4864d8441 100644
> > --- a/lib/libbearssl/Makefile.inc
> > +++ b/lib/libbearssl/Makefile.inc
> > @@ -4,4 +4,4 @@ BEARSSL?=3D ${SRCTOP}/contrib/bearssl
> >=C2=A0 BEARSSL_SRC=3D ${BEARSSL}/src
> >
> >=C2=A0 CFLAGS+=3D -I${BEARSSL}/inc
> > -
> > +CFLAGS+=3D ${NO_WDEPRECATED_NON_PROTOTYPE}
> >
>
> I went ahead and committed this. Please let me know if the problem per= sists.

Sorry for the late reply. I just tried a fresh build and it still fails wit= h

[..]/src/contrib/bearssl/src/rsa/rsa_i62_keygen.c:43:22: error: a function<= br> declaration without a prototype is deprecated in all versions of C [-Werror= ,-Wstrict-prototypes]
=C2=A0 br_rsa_i62_keygen_get()

Did you see any other possibilty to fix this?

Oh, maybe add -Wno-strict-prototypes to where I added NO_WDEPRECATED= _NON_PROTOTYPES?

Warner
--000000000000f6d36105f50806c5--