From owner-svn-src-head@FreeBSD.ORG  Mon Nov 11 19:38:22 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id F2A68305;
 Mon, 11 Nov 2013 19:38:21 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id DD86B210A;
 Mon, 11 Nov 2013 19:38:20 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
 by cell.glebius.int.ru (8.14.7/8.14.7) with ESMTP id rABJcIhO019525
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Mon, 11 Nov 2013 23:38:18 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebius.int.ru (8.14.7/8.14.7/Submit) id rABJcIq0019524;
 Mon, 11 Nov 2013 23:38:18 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Mon, 11 Nov 2013 23:38:18 +0400
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Eitan Adler <eadler@freebsd.org>
Subject: Re: svn commit: r257945 - head/usr.sbin/pkg
Message-ID: <20131111193818.GA7577@FreeBSD.org>
References: <201311110744.rAB7iA6g041490@svn.freebsd.org>
 <20131111153544.GI98118@admin.xzibition.com>
 <CAF6rxgm73FnyFgGcD2YA0MZ3Q=sHpqmS3QAbsP8BV2Qyx2z7mw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAF6rxgm73FnyFgGcD2YA0MZ3Q=sHpqmS3QAbsP8BV2Qyx2z7mw@mail.gmail.com>
User-Agent: Mutt/1.5.22 (2013-10-16)
Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "src-committers@freebsd.org" <src-committers@freebsd.org>,
 Bryan Drewery <bryan@shatow.net>
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Nov 2013 19:38:22 -0000

On Mon, Nov 11, 2013 at 02:19:38PM -0500, Eitan Adler wrote:
E> On Mon, Nov 11, 2013 at 10:35 AM, Bryan Drewery <bryan@shatow.net> wrote:
E> > On Mon, Nov 11, 2013 at 07:44:10AM +0000, Gleb Smirnoff wrote:
E> >> Author: glebius
E> >> Date: Mon Nov 11 07:44:09 2013
E> >> New Revision: 257945
E> >> URL: http://svnweb.freebsd.org/changeset/base/257945
E> >>
E> >> Log:
E> >>   Do not use just freed memory.
E> >>
E> >>   Sponsored by:       Nginx, Inc.
E> >
E> > Can you please also MFC this?
E> >
E> >>               if (fingerprint->name)
E> >>                       free(fingerprint->name);
E> 
E> While here, can you remove the if conditional by the free?

I'll do the MFC, but this styling issue I'd leave to pkg developers.

-- 
Totus tuus, Glebius.