From owner-svn-src-head@freebsd.org Wed Dec 13 06:54:45 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0913CE933E2; Wed, 13 Dec 2017 06:54:45 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D3514649D6; Wed, 13 Dec 2017 06:54:44 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 234FC1E887; Wed, 13 Dec 2017 06:54:44 +0000 (UTC) Date: Wed, 13 Dec 2017 06:54:44 +0000 From: Alexey Dokuchaev To: rgrimes@freebsd.org Cc: Warner Losh , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r326809 - head/sys/dev/cardbus Message-ID: <20171213065443.GA31341@FreeBSD.org> References: <201712122022.vBCKM9Kd050769@repo.freebsd.org> <201712122039.vBCKdcV8088346@pdx.rh.CN85.dnsmgr.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201712122039.vBCKdcV8088346@pdx.rh.CN85.dnsmgr.net> User-Agent: Mutt/1.9.1 (2017-09-22) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Dec 2017 06:54:45 -0000 On Tue, Dec 12, 2017 at 12:39:38PM -0800, Rodney W. Grimes wrote: > > New Revision: 326809 > > URL: https://svnweb.freebsd.org/changeset/base/326809 > > > > Log: > > 1k objects on the stack are a bad idea. While it's likely safe in this > > context, it's also safe to allocate the memory and free it instead. > > > > Noticed by: Eugene Grosbein's script > > YEA!!! One down, 20 to go and then see how the kstack issue does? > > And thank you for quickly fixing this. It's very promising to see debloat-type of work having started. On the related note, what is current consensus with r326758, is it going to be backed out and stack issues investigated and fixed? I am worried since kib@ had mentioned that he's "almost sure that [32-bit x86 workstation] users would get troubles now" [*] and I'm one of them. ./danfe [*] https://lists.freebsd.org/pipermail/svn-src-head/2017-December/107237.html