From owner-freebsd-x11@FreeBSD.ORG Thu Feb 13 21:52:59 2014 Return-Path: Delivered-To: freebsd-x11@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 92D94994; Thu, 13 Feb 2014 21:52:59 +0000 (UTC) Received: from ravenloft.kiev.ua (ravenloft.kiev.ua [94.244.131.95]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 2054E185C; Thu, 13 Feb 2014 21:52:59 +0000 (UTC) Date: Thu, 13 Feb 2014 23:52:57 +0200 From: Alex Kozlov To: Robert Millan Subject: Re: [PATCH] do not feed keyboard device path in X devd backend Message-ID: <20140213215257.GA12243@ravenloft.kiev.ua> References: <52EFA9A9.2040901@freebsd.org> <52F61969.2060503@freebsd.org> <20140208135404.GA75736@ravenloft.kiev.ua> <52F63866.80505@freebsd.org> <20140209102615.GA11713@ravenloft.kiev.ua> <52FCEC09.8080409@freebsd.org> <20140213162822.GA5118@ravenloft.kiev.ua> <52FD39F8.5090708@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52FD39F8.5090708@freebsd.org> Cc: freebsd-x11@freebsd.org X-BeenThere: freebsd-x11@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: X11 on FreeBSD -- maintaining and support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Feb 2014 21:52:59 -0000 On Thu, Feb 13, 2014 at 09:32:40PM +0000, Robert Millan wrote: > On 13/02/2014 16:28, Alex Kozlov wrote: > >> [ 1002.547] (EE) Keyboard: cannot open "/dev/ukbd0" > >> [ 1002.547] (EE) PreInit returned 8 for "Keyboard" > >> [ 1002.547] (II) UnloadModule: "kbd" > > This should be worked around by the next code: > > > > 269 + if (attrs.flags & ATTR_KEYBOARD) { > > 270 + /* > > 271 + * Don't pass device option if keyboard is attached to console (open fails), > > 272 + * thus activating special logic in xf86-input-keyboard. > > 273 + */ > > 274 + fd = open(path, O_RDONLY | O_NONBLOCK | O_EXCL); > > 275 + if (fd > 0) { > > 276 + close(fd); > > 277 + options = input_option_new(options, "device", path); > > 278 + } > > 279 + } else { > > 280 + options = input_option_new(options, "device", path); > > 281 + } > > Where's this code? I can't see it in x11-servers/xorg-server/files/extra-config_devd.c http://trillian.chruetertee.ch/ports/browser/trunk/x11-servers/xorg-server/files/extra-devd plus http://trillian.chruetertee.ch/ports/browser/trunk/x11-servers/xorg-server/files/extra-new-config_devd You need revision 1282 of x11-servers/xorg-server. > >> [ 1002.547] (II) config/devd: Adding input device Keyboard (/dev/atkbd0) > >> [ 1002.547] (**) Keyboard: Applying InputClass "kbd catchall" > >> [ 1002.547] (II) Using input driver 'kbd' for 'Keyboard' > >> [ 1002.547] (**) Keyboard: always reports core events > >> [ 1002.547] (**) Keyboard: always reports core events > >> [ 1002.547] (**) Option "Protocol" "standard" > >> [ 1002.547] (**) Option "Device" "/dev/atkbd0" > >> [ 1002.547] (EE) Keyboard: cannot open "/dev/atkbd0" > >> [ 1002.547] (EE) PreInit returned 8 for "Keyboard" > >> [ 1002.547] (II) UnloadModule: "kbd" > > Btw, why both your keyboards are attached to console? > I only have one keyboard (USB). I have no idea why does atkbd0 exist (but luckily > its presence doesn't harm). Hmm, I would like to see a log with up-to-date patch from xorg-dev. -- Alex