From owner-svn-src-all@freebsd.org Mon Jul 18 19:14:44 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7E376B9D76D; Mon, 18 Jul 2016 19:14:44 +0000 (UTC) (envelope-from bu7cher@yandex.ru) Received: from forward4p.cmail.yandex.net (forward4p.cmail.yandex.net [IPv6:2a02:6b8:0:1465::14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "forwards.mail.yandex.net", Issuer "Yandex CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id ED7181B27; Mon, 18 Jul 2016 19:14:43 +0000 (UTC) (envelope-from bu7cher@yandex.ru) Received: from smtp1h.mail.yandex.net (smtp1h.mail.yandex.net [IPv6:2a02:6b8:0:f05::115]) by forward4p.cmail.yandex.net (Yandex) with ESMTP id 305162039C; Mon, 18 Jul 2016 22:14:31 +0300 (MSK) Received: from smtp1h.mail.yandex.net (localhost [127.0.0.1]) by smtp1h.mail.yandex.net (Yandex) with ESMTP id 2D7E51340354; Mon, 18 Jul 2016 22:14:31 +0300 (MSK) Received: by smtp1h.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id QbgBrklslL-EUWSFm99; Mon, 18 Jul 2016 22:14:30 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1468869270; bh=FXJyvP/5852d++VhK9pBE3Tf2NFB9UM7aVKUA/DRiPE=; h=Subject:To:References:Cc:From:Message-ID:Date:In-Reply-To; b=jbKnqjWsc8hFW69cNsTupRIDdMzSEN4lubyM3bMVrMS4u8UCeCTLvjws4rNLwCQ4i 1egTxWiZyXKmmuA8j4e2FrudU7wwQkQecHUOXh9XfH7pTv8aDc/f1PxfwfTyqUVRFC ymKt/XxSw5A7ByIjiR2Oj4nJOKfHUTZrAhAwSSaM= Authentication-Results: smtp1h.mail.yandex.net; dkim=pass header.i=@yandex.ru X-Yandex-Suid-Status: 1 0,1 0,1 0,1 0 Subject: Re: svn commit: r302985 - head/sys/geom/label To: Maxim Sobolev References: <201607180500.u6I501CX063743@repo.freebsd.org> <20ae3dfe-96f4-c897-67d0-71bb94d14858@yandex.ru> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: "Andrey V. Elsukov" Message-ID: <61cba001-2717-49ee-843e-5ed6d18fa17b@yandex.ru> Date: Mon, 18 Jul 2016 22:13:31 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ueGpDXr6A1K3eXTg85Ifr9keESwJkPJ5Q" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jul 2016 19:14:44 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ueGpDXr6A1K3eXTg85Ifr9keESwJkPJ5Q Content-Type: multipart/mixed; boundary="CnHlJHfBC52c2jQvNlb5Aw9bv8gw2eqNq" From: "Andrey V. Elsukov" To: Maxim Sobolev Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <61cba001-2717-49ee-843e-5ed6d18fa17b@yandex.ru> Subject: Re: svn commit: r302985 - head/sys/geom/label References: <201607180500.u6I501CX063743@repo.freebsd.org> <20ae3dfe-96f4-c897-67d0-71bb94d14858@yandex.ru> In-Reply-To: --CnHlJHfBC52c2jQvNlb5Aw9bv8gw2eqNq Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 18.07.16 17:24, Maxim Sobolev wrote: > Andrey, are you talking about this: >=20 > --- > r156299 | pjd | 2006-03-04 11:41:54 -0800 (=D1=81=D0=B1, 04 =D0=BC=D0=B0= =D1=80 2006) | 11 lines >=20 > We need to check if file system size is equal to provider's size, becau= se > sysinstall(8) still bogusly puts first partition at offset 0 instead of= 16, > so glabel/ufs will find file system on slice instead of partition. >=20 > Before sysinstall is fixed, we must keep this code, which means that we= > wont't be able to detect UFS file systems created with 'newfs -s ...'. >=20 > PS. bsdlabel(8) creates partitions properly. >=20 > MFC after: 3 days > --- >=20 > In which case this particular change has a better chance of working > since it's not removing this check but making it less strict. Therefore= > it might attach to a wrong provider only if first UFS slice is the only= > one slice on partition (or if the other partition is very small - less > than 256 blocks in size). In either of those cases I don't think it > makes much difference if we are attaching to a slice or a partition. No, I mean r235918, that was reverted after several complains. UFS label is a special label. It always had the same size that provider. Now it will attach to first provider that will be tasted. It can be gmirror, generic glabel, geli, gpart, mbr, whole disk. https://lists.freebsd.org/pipermail/freebsd-geom/2009-April/003473.html --=20 WBR, Andrey V. Elsukov --CnHlJHfBC52c2jQvNlb5Aw9bv8gw2eqNq-- --ueGpDXr6A1K3eXTg85Ifr9keESwJkPJ5Q Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEvBAEBCAAZBQJXjSpcEhxidTdjaGVyQHlhbmRleC5ydQAKCRABxeoEEMihejOx B/9DwDnHZOgrc/BmUPhgptCCCJR9ZElPnKvqqCQrO4hwLaOhaAHRSD/FwV3168eD Nd8YQn3rK5Sx8oEgDtEymzp0y/crCRmX7d5fbliqPW3atvlNVzEhPEvGByLbW06s Tg11jLnjQLwFAYrf5JQZU5h68nVggRNSJ2T1e6ZTl/pdFbblxViXkLfvVeGdieKP edtnIb37lNzsoLpniwfibRFB5iXGWE0YDQC7cSfYuDQXw/1/TMV6W3xZrXwk77/r uF+5nqXc3zpzoMrGMyenBC7PrCKRbJ46IOMHsXBM2hO+Y0NrOHjLr1Don4Lp16EI FdHOTBffUR8xRgfJ+LuAxVQ5 =toTJ -----END PGP SIGNATURE----- --ueGpDXr6A1K3eXTg85Ifr9keESwJkPJ5Q--