Date: Wed, 20 Sep 2006 23:15:11 +0400 From: Ruslan Ermilov <ru@FreeBSD.org> To: Maksim Yevmenkin <maksim.yevmenkin@gmail.com> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Marius Strobl <marius@alchemy.franken.de> Subject: Re: cvs commit: src/sys/dev/kbdmux kbdmux.c Message-ID: <20060920191511.GC28844@rambler-co.ru> In-Reply-To: <bb4a86c70609201204n499a5bc2mb8023c502937a275@mail.gmail.com> References: <20060919221404.GT94944@alchemy.franken.de> <20060920055715.GA81843@rambler-co.ru> <20060920121017.GU94944@alchemy.franken.de> <20060920122830.GB982@rambler-co.ru> <20060920162105.GC9976@rambler-co.ru> <bb4a86c70609200928i4196c7ceu1a958d815728a5d7@mail.gmail.com> <20060920163710.GA28144@rambler-co.ru> <bb4a86c70609200944x32c0c3cfu60190684f654a642@mail.gmail.com> <20060920185618.GA28844@rambler-co.ru> <bb4a86c70609201204n499a5bc2mb8023c502937a275@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Sep 20, 2006 at 12:04:49PM -0700, Maksim Yevmenkin wrote:
> ok, i just tested the following patch on sparc64 and it makes
> 'kbdcontrol -k' work as expected. i can now switch between ukbd0 and
> sunkbd0 without any problems.
>
> --- syscons.c.orig Fri Mar 3 16:41:28 2006
> +++ syscons.c Wed Sep 20 09:57:09 2006
> @@ -1194,7 +1194,7 @@
> keyboard_t *newkbd;
>
> s = spltty();
> - newkbd = kbd_get_keyboard(*(int *)data);
> + newkbd = kbd_get_keyboard(*(intptr_t *)data);
> if (newkbd == NULL) {
> splx(s);
> return EINVAL;
>
> can i commit it?
>
> thanks,
> max
>
> p.s. yes, i know, there are few other ioctl's with the same problem. i
> just want to address it one ioctl at a time :)
>
Please don't. I have this fix already locally,
- newkbd = kbd_get_keyboard(*(int *)data);
+ newkbd = kbd_get_keyboard((int)*(intptr_t *)data);
but I'm also discussing the gory details with Bruce Evans,
and I don't want to do multiple commits if it turns out
that we need a slightly different technique. Please keep
the file locally until I send the whole patch.
Cheers,
--
Ruslan Ermilov
ru@FreeBSD.org
FreeBSD committer
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060920191511.GC28844>