From nobody Tue Nov 26 15:50:06 2024 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XyRq26l59z5fdPS for ; Tue, 26 Nov 2024 15:50:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XyRq25Rrzz4k6k for ; Tue, 26 Nov 2024 15:50:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1732636206; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KY9NBHHLQYsABQlv1ncKWGcgx/4XvkQbspopnq/kjLg=; b=k8KdnXjvTREd2AQtXj0FNV5UzaZLt2vEj5SfPyIOnC/cEP5cka9MJXvpj+okH7ZDtRmSdK fMb4b/y2BPBJe9CeRun0qa/muAs0Xuuroj/LBVTaVat5r+872Z2p/tk91mBYgxeRmjDzwj iwka5+4XSoGVG8NdtoEnWxZs7wpcFQ8/fPLmqgNzcLt46DvI5GqNjLUoVve4r+epq/iHfh wCeeapyxpTDZYtVQSYU47IDlAYlmNtwBgVTUsYh78JZlkkMQ5rt9CGRbCk7J3FOXfbbeQk dYOKy727iHLkthgLZEaVG6I4y0uy8ZxAT4xvYiMmDmZqDeDJO+DMzrtc0+UqQA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1732636206; a=rsa-sha256; cv=none; b=b9iXSOp4F0Ly+y+a9oy0aCLoKq0plupr8qFgDsPbTrhh4BxdKBl4Fh7K1o+0K/gp0/BDk7 vYyR6u6M//1PHbvBXhvEvfgD6wcjZr/YKHIFSQYORz6KAdIUblfoIwt085rltl8R4NWDb/ UnZnko0+7izmACEfFYnJu+rcaMKmEIBzIlOg1+RPr0B51a+FEIvGsKU9yd68pb9i4UHDSZ ldIm03V/4EiEN96FgG+tH/w7HlDWal+ZfwBk8gtyYnTWa+7os9U1FV3ozUU31TjaiJduaG 3p8tgpcYvuAthPMWINiqLJICWEhhVgmxWRSqlgGEnk8DK/YS7cr3t1L9M1DBOA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XyRq24xGgzXH9 for ; Tue, 26 Nov 2024 15:50:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 4AQFo6tn044119 for ; Tue, 26 Nov 2024 15:50:06 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 4AQFo6Pe044116 for bugs@FreeBSD.org; Tue, 26 Nov 2024 15:50:06 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 282984] [PATCH] pfctl: add -T `makezero` to touch pfras_tzero _only_ for non-zero entries Date: Tue, 26 Nov 2024 15:50:06 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 14.1-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: leon+freebsd@darkk.net.ru X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D282984 --- Comment #4 from Leonid Evdokimov --- Rob, thanks for your input. I completely agree with your reasoning, but I r= each different conclusion starting with a similar idea. "expire" also falls under the category "one has all the information and functionality" combining "show" and "delete". Moreover, it's implemented in exactly that way: https://github.com/freebsd/freebsd-src/blob/435a5f94fbc09959c0a4e48b1e81a50= fcfd45673/sbin/pfctl/pfctl_table.c#L259-L296 So, I concluded, if "expire" is eligible for pfctl as it codifies a helper = for a reasonably popular policy, something like "makezero" is somewhat equally eligible. That's why I decided to submit a patch instead of making an ad-hoc for(;;){show|delete;sleep} script. I also agree, that it would be nice of kernel to keep track of time of last increment of a counter to make things more real-time (and, maybe, make it CLOCK_UPTIME_FAST instead of wall-clock), but I'm not in the position to develop alike patch as packet counters are on a critical path of network forwarding and I'm not capable of benchmarking the patch on a reasonably diverse set of hardware (L1/2/3 cache-sizes might matter) as alike patch may interfere with some structures being pushed out of CPU caches and introduci= ng performance regression as a consequence. --=20 You are receiving this mail because: You are the assignee for the bug.=