From owner-p4-projects  Sun Dec 22 14:11: 9 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 7917C37B401; Sun, 22 Dec 2002 14:11:07 -0800 (PST)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 0EA6937B406; Sun, 22 Dec 2002 14:11:07 -0800 (PST)
Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 0E3C243ED8; Sun, 22 Dec 2002 14:11:06 -0800 (PST)
	(envelope-from imp@bsdimp.com)
Received: from localhost (warner@rover2.village.org [10.0.0.1])
	by harmony.village.org (8.12.6/8.12.3) with ESMTP id gBMMB5uB071544;
	Sun, 22 Dec 2002 15:11:05 -0700 (MST)
	(envelope-from imp@bsdimp.com)
Date: Sun, 22 Dec 2002 15:10:26 -0700 (MST)
Message-Id: <20021222.151026.100645554.imp@bsdimp.com>
To: marcel@freebsd.org
Cc: perforce@freebsd.org
Subject: Re: PERFORCE change 22626 for review
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <200212221927.gBMJR0si013191@repoman.freebsd.org>
References: <200212221927.gBMJR0si013191@repoman.freebsd.org>
X-Mailer: Mew version 2.1 on Emacs 21.2 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG

In message: <200212221927.gBMJR0si013191@repoman.freebsd.org>
            Marcel Moolenaar <marcel@freebsd.org> writes:
:  static int
:  sio_pccard_detach(dev)
:  	device_t	dev;
:  {
: -	return (siodetach(dev));
: +	/* XXX broken */
:  }

This is clearly not acceptible.

Warner

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message