From owner-cvs-src@FreeBSD.ORG Sun Oct 10 09:32:12 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CEFA616A4CE; Sun, 10 Oct 2004 09:32:12 +0000 (GMT) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 15D7E43D69; Sun, 10 Oct 2004 09:32:12 +0000 (GMT) (envelope-from glebius@freebsd.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.12.11/8.12.8) with ESMTP id i9A9VwHQ011639 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 10 Oct 2004 13:31:59 +0400 (MSD) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.sick.ru (8.12.11/8.12.11/Submit) id i9A9VwOt011638; Sun, 10 Oct 2004 13:31:58 +0400 (MSD) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@freebsd.org using -f Date: Sun, 10 Oct 2004 13:31:57 +0400 From: Gleb Smirnoff To: Sam Leffler Message-ID: <20041010093157.GA11523@cell.sick.ru> References: <200410091325.i99DPK00097724@repoman.freebsd.org> <4168009A.303@errno.com> <20041009213710.GB8922@cell.sick.ru> <41686584.6070606@errno.com> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <41686584.6070606@errno.com> User-Agent: Mutt/1.5.6i cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/sys mbuf.h src/sys/kern uipc_mbuf2.c src/share/man/man9 mbuf_tags.9 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Oct 2004 09:32:13 -0000 Sam, The change is reverted. On Sat, Oct 09, 2004 at 03:26:12PM -0700, Sam Leffler wrote: S> 1. You changed this without discussion. S> 2. It breaks the intentional purpose of subclassing the m_tag_free method. S> 3. Openbsd compatibility is not broken by calling through the method S> pointer; in fact calling through the method pointer is required to S> maintain compatbility (think about it). It is broken since in OpenBSD and FreeBSD function with same name do different things. S> You did not find existing uses of subclassing because I backed out the S> vlan changes to use a private pool for unrelated reasons. I very very S> strongly disagree with this change and want it reverted. This was not broken. Look in my changes to uipc_mbuf2.c, you'll see that m_tag_delete() was changed so that it calls free thru method pointer. As I said, I've checked all m_tag_free() consumers, and nothing is affected. My main purpose for this change was to create a possibility to create a custom free method, which inherits default method. How it is possible to do it now, without API change? -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE