From owner-svn-src-all@FreeBSD.ORG Wed Feb 20 11:27:07 2013 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 651F32DD; Wed, 20 Feb 2013 11:27:07 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from fallbackmx07.syd.optusnet.com.au (fallbackmx07.syd.optusnet.com.au [211.29.132.9]) by mx1.freebsd.org (Postfix) with ESMTP id D038F950; Wed, 20 Feb 2013 11:27:06 +0000 (UTC) Received: from mail27.syd.optusnet.com.au (mail27.syd.optusnet.com.au [211.29.133.168]) by fallbackmx07.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id r1KBQxLi027311; Wed, 20 Feb 2013 22:26:59 +1100 Received: from c211-30-173-106.carlnfd1.nsw.optusnet.com.au (c211-30-173-106.carlnfd1.nsw.optusnet.com.au [211.30.173.106]) by mail27.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id r1KBQl5T003031 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 20 Feb 2013 22:26:48 +1100 Date: Wed, 20 Feb 2013 22:26:47 +1100 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Andrey Zonov Subject: Re: svn commit: r246033 - head/usr.bin/systat In-Reply-To: <5107BC87.4080403@FreeBSD.org> Message-ID: <20130220220256.X856@besplex.bde.org> References: <201301281257.r0SCvhhv071414@svn.freebsd.org> <20130129003913.G2698@besplex.bde.org> <5107BC87.4080403@FreeBSD.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.0 cv=KZ6KKnkD c=1 sm=1 a=VYs4l19NTHwA:10 a=kj9zAlcOel0A:10 a=PO7r1zJSAAAA:8 a=JzwRw_2MAAAA:8 a=hP3lJxi6wgAA:10 a=NEAV23lmAAAA:8 a=ZS0bOJEMWNEgiowcFE4A:9 a=CjuIK1q_8ugA:10 a=TEtd8y5WR3g2ypngnwZWYw==:117 Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Bruce Evans X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Feb 2013 11:27:07 -0000 On Tue, 29 Jan 2013, Andrey Zonov wrote: > On 1/28/13 6:51 PM, Bruce Evans wrote: >> On Mon, 28 Jan 2013, Andrey Zonov wrote: >> >>> Log: >>> - Show page faults requiring I/O on vmstat display. >> >> No space is available there for showing it. > > Yep, you're right. >>> + mvprintw(VMSTATROW, VMSTATCOL + 9, "ioflt"); >> >> Putting it first unsorts the fields a bit and makes the diff large. >> >> It is not documented in the man page. > > Fixed in attached systat1.patch.txt. OK. >> ... >> "buf" is even more useless with zfs. So are some of the other fields >> ... > > I totally agree with you, 'buf' should go away from systat and top. I > removed 'buf' from systat. Please review systat2.patch.txt. I'd just like it to be replaced by a useful buf field someday. Since the field in row 23 (starting at row 0) is now useful, omitting it is not so good so I I agree with your patch removing the special code to avoid printing it on 24-row terminals. > To count 'disk cache' we have to add new counter which should track all > pages with OBJT_VNODE type. It doesn't look hard to implement this. I > wrote utility [1] which allows me to inspect memory and find what is in > disk cache. I think I would like at least 2 fields: - total disk space mapped in VMIO buffers - total disk space mapped in the buffer cache. > I also found that %ozfod is not useful for me and I removed it to not > mangle 'free' on 24-line terminals (systat3.patch.txt). Certainly no space is available for the luxury of both ozfod and %ozfod. That would also allow leaving buf and its 24-column support alone. Only 3 fields would move relative to the old version (not just 1 field changing for swapping %ozfod with the new field, since you want to put the new field first). Are the other fields in the best order? I think they are. If not, it would be good to move some when adjusting all the row numbers. > Thanks for comments! > > [1] https://github.com/z0nt/meminfo/ Bruce