From owner-cvs-src@FreeBSD.ORG Wed May 31 14:27:25 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AB7EC16B2F8; Wed, 31 May 2006 14:27:25 +0000 (UTC) (envelope-from mj@feral.com) Received: from ns1.feral.com (ns1.feral.com [192.67.166.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2569843D46; Wed, 31 May 2006 14:27:25 +0000 (GMT) (envelope-from mj@feral.com) Received: from ns1.feral.com (localhost [127.0.0.1]) by ns1.feral.com (8.13.6/8.13.6) with ESMTP id k4VERO4X072820; Wed, 31 May 2006 07:27:24 -0700 (PDT) (envelope-from mj@feral.com) Received: from localhost (mjacob@localhost) by ns1.feral.com (8.13.6/8.13.6/Submit) with ESMTP id k4VEROUu072817; Wed, 31 May 2006 07:27:24 -0700 (PDT) (envelope-from mj@feral.com) X-Authentication-Warning: ns1.feral.com: mjacob owned process doing -bs Date: Wed, 31 May 2006 07:27:24 -0700 (PDT) From: Matthew Jacob X-X-Sender: mjacob@ns1.feral.com To: Matthew Jacob In-Reply-To: <20060531071852.Q72653@ns1.feral.com> Message-ID: <20060531072706.U72653@ns1.feral.com> References: <200605310930.k4V9UpWa001360@gw.catspoiler.org> <20060531071852.Q72653@ns1.feral.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, Don Lewis , src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/cam cam_xpt.c src/sys/cam/scsi scsi_all.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Matthew Jacob List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 14:27:30 -0000 Sorry- my bad- I did this for amd64 and somehow missed my checklist to do it also on i386. On Wed, 31 May 2006, Matthew Jacob wrote: > > *blink*? It did break things? My apologies- I could have sworn that I'd done > a LINT check. Sorry- I'll get right on this. > > On Wed, 31 May 2006, Don Lewis wrote: > >> On 30 May, Matt Jacob wrote: >>> mjacob 2006-05-30 22:44:00 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/cam cam_xpt.c >>> sys/cam/scsi scsi_all.h >>> Log: >>> Handle some of the inquiry flags that have come into >>> usage as of SPC2r20. Specifically, handle the BQueue >>> flag which will indicate that a device supports the >>> Basic Queueing model (no Head of Queue or Ordered tags). >>> When this flag is set, SID_CmdQueue is clear. This has >>> causes FreeBSD to assume that the device did not support >>> tagged operations. >> >> This commit broke compilation of the ahb driver, which appears to be >> trying to get the number of ecbs from the spc2_flags member of >> scsi_inquiry_data, which it tries to access under the old member name, >> reserved[1]. Not that I care all that much because I don't have any ahb >> hardware, but this driver is included in the GENERIC kernel. >> >> >