From owner-freebsd-bugs@freebsd.org Sat Feb 24 13:11:03 2018 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 59F42F1000B for ; Sat, 24 Feb 2018 13:11:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E957781497 for ; Sat, 24 Feb 2018 13:11:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 03544129D5 for ; Sat, 24 Feb 2018 13:11:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w1ODB1gq000982 for ; Sat, 24 Feb 2018 13:11:01 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w1ODB1OB000981 for freebsd-bugs@FreeBSD.org; Sat, 24 Feb 2018 13:11:01 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 226166] [PATCH] fts(3): setting FTS_FOLLOW for children does not work as expected when FTS_NOCHDIR is set Date: Sat, 24 Feb 2018 13:11:01 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: jan.kokemueller@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status keywords bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Feb 2018 13:11:03 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D226166 Bug ID: 226166 Summary: [PATCH] fts(3): setting FTS_FOLLOW for children does not work as expected when FTS_NOCHDIR is set Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Keywords: patch Severity: Affects Some People Priority: --- Component: bin Assignee: freebsd-bugs@FreeBSD.org Reporter: jan.kokemueller@gmail.com Keywords: patch Created attachment 190957 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D190957&action= =3Dedit patch to fix FTS_FOLLOW when set on entries returned by fts_children() Reading the fts(3) man page something like the example below should work. T= his sets FTS_FOLLOW on a child named 'symlink' which is a symlink to another folder. fts_read will now recurse into this folder, even though FTS_PHYSICA= L is set. Right now it won't recurse, however, when FTS_NOCHDIR is also set. The problem is a stale fts_accpath. This leads to fts_stat() calling stat on the wrong file. The attached patch attempts to fix this by switching the or= der of the fts_stat() and the fts_accpath update. #include #include #include #include #include int main() { FTS *fts; FTSENT *ftsent, *children; char *fts_args[] =3D { ".", NULL }; fts =3D fts_open(fts_args, FTS_PHYSICAL | FTS_NOCHDIR, NULL); if (!fts) { err(1, "fts"); } while ((ftsent =3D fts_read(fts))) { fprintf(stderr, "got file: %s\n", ftsent->fts_path); children =3D fts_children(fts, 0); for (FTSENT *child =3D children; child; child =3D child->fts_link) { if (!strcmp("symlink", child->fts_name)) { if (fts_set(fts, child, FTS_FOLLOW)) { err(1, "fts_set"); } } } } if (fts_close(fts) < 0) { warn("fts_close"); } } --=20 You are receiving this mail because: You are the assignee for the bug.=