From owner-freebsd-net Sat Nov 23 12:17:56 2002 Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B6ECD37B401 for ; Sat, 23 Nov 2002 12:17:55 -0800 (PST) Received: from mel-rto3.wanadoo.fr (smtp-out-3.wanadoo.fr [193.252.19.233]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6964843E88 for ; Sat, 23 Nov 2002 12:17:54 -0800 (PST) (envelope-from vjardin@wanadoo.fr) Received: from mel-rta7.wanadoo.fr (193.252.19.61) by mel-rto3.wanadoo.fr (6.5.007) id 3DDA12BC00320796 for freebsd-net@freebsd.org; Sat, 23 Nov 2002 21:17:53 +0100 Received: from there (80.11.204.20) by mel-rta7.wanadoo.fr (6.5.007) id 3DD3B25600551D5F for freebsd-net@freebsd.org; Sat, 23 Nov 2002 21:17:53 +0100 Message-ID: <3DD3B25600551D5F@mel-rta7.wanadoo.fr> (added by postmaster@wanadoo.fr) Content-Type: text/plain; charset="iso-8859-15" From: Vincent Jardin To: freebsd-net@freebsd.org Subject: a ng_pppoe bug ? Date: Sat, 23 Nov 2002 21:35:24 +0100 X-Mailer: KMail [version 1.3.2] MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Hi, I am wondering if it is a bug of ng_pppoe. The objects that have the structure sess_neg hold a pointer on the last sent packet. struct sess_neg { struct mbuf *m; /* holds cluster with last sent packet */ union packet *pkt; /* points within the above cluster */ (...) Then when a packet is made, the same mbuf is always reused. However, m_data might have been changed by another node or a driver (for example, there are some pieces of code that translate m_data: m_data += n). It means that the second time a pppoe packet is sent during the negocation, a part of the ethernet header is missing. It think that the problem is related to m_copypacket that is used within ng_ppppoe in order to keep always the same mbuf. Vincent To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message