From owner-freebsd-current@FreeBSD.ORG Thu May 5 05:20:31 2011 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9119F106566B for ; Thu, 5 May 2011 05:20:31 +0000 (UTC) (envelope-from lacombar@gmail.com) Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id 4B7D58FC1D for ; Thu, 5 May 2011 05:20:30 +0000 (UTC) Received: by iwn33 with SMTP id 33so2154224iwn.13 for ; Wed, 04 May 2011 22:20:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=JbG+DGTGRJ2H31sWa1Qq/BycmSLOP/2ZYxNLEzJM/LQ=; b=iMS4jZVifFqXpEULH1+HyXwSyqmdup4XYacUo/HJeurXtSq3koxtnOFwxidbAlz2hr 8kcVg4iOkYtPFRi2i3Dds4VUIgcEztZyATB5H4AodU+qYLhjsQkh4iJ1sO9YjMDgAPaF h2Nvx7xWeq7D27XTuBTfr/PWWi+MF3cOrUsR0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=t+yXgSKgd51AGjyPpMhneBUhbdUQFmEBtVTm1ZEBLrAe62n4znQQFjEHZCTIV2B0tI 2AsnOPUCs9jwtKYnA1F5FRBfx+lm7J0ffoHcahvNbzWt5efwA/57jNK7+7yOqa20ZLeu i0FuOUFUZZg/EL9g46Kr1lKEhD2ZUSRqJmBCY= MIME-Version: 1.0 Received: by 10.42.151.73 with SMTP id d9mr56547icw.2.1304572830501; Wed, 04 May 2011 22:20:30 -0700 (PDT) Received: by 10.42.167.5 with HTTP; Wed, 4 May 2011 22:20:30 -0700 (PDT) In-Reply-To: References: <4D94A354.9080903@sentex.net> <4DC07013.9070707@gmx.net> <4DC078BD.9080908@gmx.net> Date: Thu, 5 May 2011 01:20:30 -0400 Message-ID: From: Arnaud Lacombe To: Jack Vogel Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Olivier Smedts , FreeBSD current mailing list Subject: Re: problems with em(4) since update to driver 7.2.2 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2011 05:20:31 -0000 Hi, On Wed, May 4, 2011 at 5:38 PM, Jack Vogel wrote: > I have had my validation engineer busy all day, we have tried both > a 9 kernel as well as 8.2, =A0using the code from HEAD, and we > cannot reproduce this problem. > Actually, it can be trivially reproduced by tainting `error'. As it is uninitialized in HEAD, it's value can be _anything_, so let's mark it as explicitly invalid. diff -u ./if_em.c /data/src/freebsd/em-7.2.2/src/if_em.c --- ./if_em.c 2011-02-18 01:18:23.000000000 -0500 +++ /data/src/freebsd/em-7.2.2/src/if_em.c 2011-05-05 01:12:01.000000000 -0400 @@ -3912,7 +3912,7 @@ struct adapter *adapter =3D rxr->adapter; struct em_buffer *rxbuf; bus_dma_segment_t seg[1]; - int i, j, nsegs, error; + int i, j, nsegs, error =3D -1; The error pointed out in this thread pops up in the next boot. - Arnaud > The data your netstat -m shows suggests to me that what's happening > is somehow setup of the receive ring is running more than once maybe?? > > You asked at one point how this could go into STABLE, well, because > not only here at Intel, but at lots of external customers this code has b= een > used and tested thoroughly. > > I am not calling into question your problem, but until I understand what = it > is I cannot "fix" it :) > > The thing I am guessing right now is the culprit is the setup code, the > reason > is that when I ported to the igb driver I found that it did not work on o= ur > newer > hardware, and so I went back to the older version of setup for igb. Now, > even > though I have not seen hardware fail with em, maybe there is some. > > To help me give me a complete pciconf -lv, and if its a namebrand system > tell me that, including all hardware in it. > > If you like Olivier I can make a version of em for you that also reverts = the > setup code the way I did for igb, see if that fixes it for you? > > Thanks for your patience, > > Jack > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org= " >