From owner-freebsd-bugs@freebsd.org Sun Apr 14 20:57:53 2019 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D12BA158058F for ; Sun, 14 Apr 2019 20:57:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 62B3D8139E for ; Sun, 14 Apr 2019 20:57:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 1B6ED158058E; Sun, 14 Apr 2019 20:57:52 +0000 (UTC) Delivered-To: bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D327B158058D for ; Sun, 14 Apr 2019 20:57:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 661288139C for ; Sun, 14 Apr 2019 20:57:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 7A51F1B828 for ; Sun, 14 Apr 2019 20:57:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x3EKvoPU006287 for ; Sun, 14 Apr 2019 20:57:50 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x3EKvomq006286 for bugs@FreeBSD.org; Sun, 14 Apr 2019 20:57:50 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 237287] [patch] moused(8) ignores button release events in virtual scroll mode Date: Sun, 14 Apr 2019 20:57:50 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: bojan_petrovic@fastmail.fm X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Apr 2019 20:57:53 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D237287 Bug ID: 237287 Summary: [patch] moused(8) ignores button release events in virtual scroll mode Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: bin Assignee: bugs@FreeBSD.org Reporter: bojan_petrovic@fastmail.fm Created attachment 203676 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D203676&action= =3Dedit moused.c.diff Sometimes when I double-click a word in an X terminal to select it and then immediately click the middle button to paste it, the terminal is left in dr= ag selection mode as if the left button was not released on the second click. This behavior can be reproduced by the following sequence when running "mou= sed" with "-V" option: 1. press and hold left button 2. press and hold middle button 3. release left button 4. release middle button The X terminal will be in drag selection mode. The debug output (grepped for "moused: button.*count") for the sequence of events above when I run moused with virtual scrolling OFF is: moused: button 1 count 1 moused: button 2 count 1 moused: button 1 count 0 moused: button 2 count 0 The debug output with virtual scrolling ON: moused: button 1 count 1 moused: button 2 count 1 moused: button 2 count 1 moused: button 2 count 0 In virtual scrolling case the button 1 count never drops to 0. In current code, the SCROLL_PREPARE mode can be entered when multiple butto= ns are held pressed, and then all of them released except for the middle butto= n: if (action0.button =3D=3D MOUSE_BUTTON2DOWN) In this mode button events are not emmited: /* Defer clicks until we aren't VirtualScroll'ing. */ if (scroll_state =3D=3D SCROLL_NOTSCROLLING) r_click(&action2); Because of this, the left button release is not registered. I've attached a patch which fixes this issue for me. It allows the virtual scroll mode to be entered only if no other button was held before pressing middle button. --=20 You are receiving this mail because: You are the assignee for the bug.=