From owner-freebsd-ports@FreeBSD.ORG Sat May 24 09:05:33 2008 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 18486106566C; Sat, 24 May 2008 09:05:33 +0000 (UTC) (envelope-from bsam@ipt.ru) Received: from services.ipt.ru (services.ipt.ru [194.62.233.110]) by mx1.freebsd.org (Postfix) with ESMTP id E58658FC0A; Sat, 24 May 2008 09:05:32 +0000 (UTC) (envelope-from bsam@ipt.ru) Received: from [85.173.16.45] (helo=localhost.my.domain) by services.ipt.ru with esmtpa (Exim 4.54 (FreeBSD)) id 1Jzpgv-0008LI-Q1; Sat, 24 May 2008 13:05:29 +0400 To: "Ganael LAPLANCHE" References: <20080524073145.M76509@martymac.com> From: Boris Samorodov Date: Sat, 24 May 2008 13:04:57 +0400 In-Reply-To: <20080524073145.M76509@martymac.com> (Ganael LAPLANCHE's message of "Sat\, 24 May 2008 10\:08\:56 +0200 \(CEST\)") Message-ID: <07923414@ipt.ru> User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: ports@freebsd.org, emulation@FreeBSD.org Subject: Re: USE_LINUX_RPM and PORTDOCS X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 May 2008 09:05:33 -0000 (the topic is emulation@ relevant, added to CC) On Sat, 24 May 2008 10:08:56 +0200 (CEST) Ganael LAPLANCHE wrote: > Hi everybody, > One of my ports, archivers/linux-par2cmdline, uses a RPM that contains > documentation, but does not (yet) handle the NOPORTDOCS option. An error is > generated in Tinderbox and complains that documentation files remain on the > filesystem after deinstallation. See : > http://t64.tecnik93.com/logs/7-STABLE-FTP/linux-par2cmdline-0.4.log > as reported by Itetcu. > My port uses both the USE_LINUX_RPM facility and PORTDOCS variable. > What happens is that passing NOPORTDOCS=yes to the port is ignored by > bsd.linux-rpm.mk's do-install target which installs documentation anyway (as any > other file). As I have also declared documentation files with the PORTDOCS > variable, they are *not* deinstalled when using NOPORTDOCS=yes. > So, I am a bit stuck since bsd.linux-rpm.mk does not seem to provide a way to > handle that case... > I see two options : > - Override the do-install target and do things manually, which seems a bad idea > since several actions are involved in installing linux files (brandelf, cpio, ...) > - Do not use PORTDOCS option anymore and treat doc files as any other file, but > this implies installing documentation files even if it has not been requested by > the user. I could even use AUTOMATIC_PLIST for that... > What would be the best option ? Would you have any other idea ? I'd suggest another option. What about fixing bsd.linux-rpm.mk? Ex., one may introduce, say, a pre-install target (or even do it at the very beginning of a do-install stage) and conditionally delete unneeded files from WRKDIR (so they won't get installed at do-install stage). -- WBR, bsam