From owner-cvs-all Mon Oct 7 12:27:32 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 37D7737B401; Mon, 7 Oct 2002 12:27:31 -0700 (PDT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6568343E9C; Mon, 7 Oct 2002 12:27:30 -0700 (PDT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.6/8.12.6) with ESMTP id g97JRJpS022629; Mon, 7 Oct 2002 21:27:23 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: John Baldwin Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/boot/i386/btx/btxldr btxldr.s In-Reply-To: Your message of "Mon, 07 Oct 2002 15:23:06 EDT." Date: Mon, 07 Oct 2002 21:27:19 +0200 Message-ID: <22628.1034018839@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message , John Baldwin writes: > >On 07-Oct-2002 Poul-Henning Kamp wrote: >> phk 2002/10/07 12:12:36 PDT >> >> Modified files: >> sys/boot/i386/btx/btxldr btxldr.s >> Log: >> Correctly adjust for moved start address. >> >> It seems that the existence of a "depend" target in src/sys/boot is not >> to be taken as an indication that it actually does what one would expect, >> at least it clearly threw my testing off. > >Well, the problem is that the boot code has a lot of indirect magic numbers >in it and there aren't any real headers that are shared for these various >things to depend on. This stuff is kind of gross. :) I was surprised to see that absolutely no common headers were used, is there a technical reason for that ? Otherwise it would be a nice improvement for the future. The good news in all of this is that it will move the 8k barrier up to 64k so a lot of this code can be written less convoluted once we get there. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message