From owner-freebsd-current@FreeBSD.ORG  Thu Mar  8 17:51:02 2012
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id A61D2106564A;
	Thu,  8 Mar 2012 17:51:02 +0000 (UTC)
	(envelope-from adrian.chadd@gmail.com)
Received: from mail-pw0-f54.google.com (mail-pw0-f54.google.com
	[209.85.160.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 679748FC19;
	Thu,  8 Mar 2012 17:51:02 +0000 (UTC)
Received: by pbcwz17 with SMTP id wz17so1989651pbc.13
	for <multiple recipients>; Thu, 08 Mar 2012 09:51:02 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:sender:in-reply-to:references:date
	:x-google-sender-auth:message-id:subject:from:to:cc:content-type
	:content-transfer-encoding;
	bh=h2+JSl0qSY/YiIotcfBU03LL9Xe3zqgeXsb+uGyi8Po=;
	b=gRoX+BDDbFpl5lKO9/v0ZeWZaf5ZUejjyPfB91nRskwmL/Bj98VCaJ43iqav2zxGha
	j4TweekS8tRQK7i1ok6F3bhf21uppWqBnd0QPNLD0Jcrn8iwiiYbWtW4bPSb9BWU7M6G
	C9/SfCF2we2QyfH+Qgnc4UUY5KJNjols3zUyv+k4MJHejii4di3o87hPMkbHSJBBLfIr
	iwvsnthWP7dR97exVYqwnmHTzzoQYaIngwAbUYSrFyg7VPOTuegu0fAaJmFBFHf35psm
	fcxOas8qww9h/5yyeofju0GECENyM8EdIqGgd/C1E9JbY5SOv/YYZuLbXwMTQIw6sbBT
	GeMQ==
MIME-Version: 1.0
Received: by 10.68.240.41 with SMTP id vx9mr11093351pbc.10.1331229062114; Thu,
	08 Mar 2012 09:51:02 -0800 (PST)
Sender: adrian.chadd@gmail.com
Received: by 10.142.72.11 with HTTP; Thu, 8 Mar 2012 09:51:02 -0800 (PST)
In-Reply-To: <20120309.023227.95065896.iwasaki@jp.FreeBSD.org>
References: <201203062005.15276.bschmidt@freebsd.org>
	<20120308.003844.08316346.iwasaki@jp.FreeBSD.org>
	<CAJ-VmomDUF2ydBfjzYaxPimZUtdCbbg2ScUz5KCw3ze3XtTmiw@mail.gmail.com>
	<20120309.023227.95065896.iwasaki@jp.FreeBSD.org>
Date: Thu, 8 Mar 2012 09:51:02 -0800
X-Google-Sender-Auth: HErUkLdsiywsQ2P8EyzWdbC3pEU
Message-ID: <CAJ-Vmo=hnWXoU4grPAf3+Gea2RA+n+tzKFrQgwnckKm9vzLxHg@mail.gmail.com>
From: Adrian Chadd <adrian@freebsd.org>
To: Mitsuru IWASAKI <iwasaki@jp.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: freebsd-current@freebsd.org, freebsd-wireless@freebsd.org,
	bschmidt@freebsd.org
Subject: Re: patches for if_iwi and wlan for WEP mode
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Mar 2012 17:51:02 -0000

On 8 March 2012 09:32, Mitsuru IWASAKI <iwasaki@jp.freebsd.org> wrote:
> Hi,
>
>> I'd rather you didn't commit iwi_update_mcast() unless you absolutely
>> know that the NIC doesn't need to be notified of multicast group
>> membership changes. If so, please commit that as a separate fix.
>
> OK, I'd do so. =A0I don't need mcast stuff for the time being,
> instead I'd check other area such as suspend/resume for the next target.
>
> Today's one at:
> http://people.freebsd.org/~iwasaki/iwi/iwi-20120308.diff
>
> # 2 lines fix, after all ;)

:-)

Thanks for this!

Once it's done, let's sort out the multicast stuff. Either we set
IFF_ALLMULTI as AK suggested or we figure out and write a proper
_update_mcast() function.

We can commit that as a separate patch.

I found my 2945 NIC btw, so hopefully I can get some test in on saturday.


Adrian