From owner-freebsd-commit  Sat Oct 28 15:54:45 1995
Return-Path: owner-commit
Received: (from root@localhost)
          by freefall.freebsd.org (8.6.12/8.6.6) id PAA07724
          for freebsd-commit-outgoing; Sat, 28 Oct 1995 15:54:45 -0700
Received: (from root@localhost)
          by freefall.freebsd.org (8.6.12/8.6.6) id PAA07710
          for cvs-all-outgoing; Sat, 28 Oct 1995 15:54:36 -0700
Received: (from root@localhost)
          by freefall.freebsd.org (8.6.12/8.6.6) id PAA07693
          for cvs-gnu-outgoing; Sat, 28 Oct 1995 15:54:32 -0700
Received: from jhome.DIALix.COM (root@jhome.DIALix.COM [192.203.228.69])
          by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id PAA07681
          ; Sat, 28 Oct 1995 15:54:24 -0700
Received: (from peter@localhost) by jhome.DIALix.COM (8.6.12/8.6.9) id GAA08401; Sun, 29 Oct 1995 06:54:12 +0800
Date: Sun, 29 Oct 1995 06:54:11 +0800 (WST)
From: Peter Wemm <peter@jhome.DIALix.COM>
To: Steven Wallace <swallace@ece.uci.edu>
cc: CVS-commiters@freefall.freebsd.org, cvs-gnu@freefall.freebsd.org
Subject: Re: cvs commit: src/gnu/usr.bin/rcs/rlog rlog.1 rlog.c 
In-Reply-To: <199510282239.PAA02672@newport.ece.uci.edu>
Message-ID: <Pine.BSF.3.91.951029064435.356C-100000@jhome.DIALix.COM>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-commit@FreeBSD.org
Precedence: bulk

On Sat, 28 Oct 1995, Steven Wallace wrote:
> 
> > hsu         95/10/28 14:51:01
> > 
> >   Modified:    gnu/usr.bin/rcs  CREDITS NEWS REFS rcstest
> ...
> 
> Why is the username listed here hsu and not peter?

Hmm. That name is coming from getlogin in the perl code.  I know the 
kernel support behind the getlogin() snd setlogin() system call is buggy 
(which is a real worry, because is meant to be a secure function, and is 
used as such for security checking around the place...).

For example, if I log in and start xdm, all of a sudden the `logname` 
(which calls the kernel getlogin() function) *changes* once somebody logs 
in on the xdm screen.  This is *after* xdm has detached from the 
launching terminal....

My guess is that 'hsu' logged in or out, or ran something in a new 
process group or session just as the log_accum.pl was being 
launched from the cvs from the rshd.

If cvs or perl can change it's secure username as a non-privileged process, 
something's wrong.

-Peter

> Steven