From owner-cvs-src@FreeBSD.ORG Sun Aug 8 05:33:22 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0F79316A4CE; Sun, 8 Aug 2004 05:33:22 +0000 (GMT) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id F285643D48; Sun, 8 Aug 2004 05:33:21 +0000 (GMT) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id E48D45C8D3; Sat, 7 Aug 2004 22:33:21 -0700 (PDT) Date: Sat, 7 Aug 2004 22:33:21 -0700 From: Alfred Perlstein To: Kris Kennaway Message-ID: <20040808053321.GD57908@elvis.mu.org> References: <200408042031.i74KVKUf039025@repoman.freebsd.org> <200408041634.03998.jhb@FreeBSD.org> <20040808042703.GA64746@xor.obsecurity.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040808042703.GA64746@xor.obsecurity.org> User-Agent: Mutt/1.4.2.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: John Baldwin Subject: Re: cvs commit: src/sys/i386/i386 pmap.c src/sys/kern subr_witness.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Aug 2004 05:33:22 -0000 * Kris Kennaway [040807 21:28] wrote: > On Wed, Aug 04, 2004 at 04:34:03PM -0400, John Baldwin wrote: > > On Wednesday 04 August 2004 04:31 pm, John Baldwin wrote: > > > jhb 2004-08-04 20:31:19 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/i386/i386 pmap.c > > > sys/kern subr_witness.c > > > Log: > > > Remove a potential deadlock on i386 SMP by changing the lazypmap ipi and > > > spin-wait code to use the same spin mutex (smp_tlb_mtx) as the TLB ipi > > > and spin-wait code snippets so that you can't get into the situation of > > > one CPU doing a TLB shootdown to another CPU that is doing a lazy pmap > > > shootdown each of which are waiting on each other. With this change, > > > only one of the CPUs would do an IPI and spin-wait at a time. > > > > Both this patch and the previous I have tested locally and also sent out to > > current@ for testing. However, I received zero feedback (not even useless > > feedback), so they may theoretically be risky. > > Isn't this the patch I tested for you and reported that it did not fix > the problem? Y'know there's some existing research on these sort of low level deadlocks, ie. how to do TLB shootdown without deadlock in: "UNIX Internals: The New Frontiers" -- - Alfred Perlstein - Research Engineering Development Inc. - email: bright@mu.org cell: 408-480-4684