From owner-freebsd-arch Thu Dec 13 16:23:10 2001 Delivered-To: freebsd-arch@freebsd.org Received: from mass.dis.org (mass.dis.org [216.240.45.41]) by hub.freebsd.org (Postfix) with ESMTP id 74B4537B405 for ; Thu, 13 Dec 2001 16:23:06 -0800 (PST) Received: from mass.dis.org (localhost [127.0.0.1]) by mass.dis.org (8.11.6/8.11.3) with ESMTP id fBE0Sol04630; Thu, 13 Dec 2001 16:28:50 -0800 (PST) (envelope-from msmith@mass.dis.org) Message-Id: <200112140028.fBE0Sol04630@mass.dis.org> To: Thomas Moestl Cc: Terry Lambert , arch@FreeBSD.org Subject: Re: Please review: changes to MI bus code for sparc64 In-Reply-To: Message from Thomas Moestl of "Thu, 13 Dec 2001 20:12:13 +0100." <20011213201213.B871@crow.dom2ip.de> Date: Thu, 13 Dec 2001 16:28:50 -0800 From: Mike Smith Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > > The PCI_BROKEN_INTPIN/PCI_INTLINE_0_BAD seem to be the same thing; > > they should be protected by a single name (probably PCI_BROKEN_INTPIN) > > in the #ifdef in pci.c; it should be "all or nothing" on a single > > value. As it is, you must define one if you define the other, but > > not vice versa, and the effect seems to be linked, anyway, so you > > might as well use a single protection mechanism. > > It is not uncommon that i386 BIOSes to set the intline register to 0 > when it should really be 0xff (to indicate an unrouted interrupt). So, > I figured that it might be useful to make this an extra option. No. Fix the i386-specific config space accessor to convert 0 to 255. If you haven't seen the theme here yet; here it is. The MD layers should correct for platform-specific aberrations in the PCI implementation where possible. Adding compile-time options to MI code which indirectly relate exclusively to MD PCI issues is just the Wrong Thing to Do. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message