From owner-cvs-src@FreeBSD.ORG Wed May 23 18:09:13 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 334BF16A468; Wed, 23 May 2007 18:09:13 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.freebsd.org (Postfix) with ESMTP id CF1F213C4C8; Wed, 23 May 2007 18:09:12 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l4NI9AWg016971; Wed, 23 May 2007 14:09:10 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Andrew Gallatin Date: Wed, 23 May 2007 13:37:33 -0400 User-Agent: KMail/1.9.6 References: <200705231531.l4NFV12H058289@repoman.freebsd.org> In-Reply-To: <200705231531.l4NFV12H058289@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200705231337.35056.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Wed, 23 May 2007 14:09:10 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/3287/Wed May 23 13:31:14 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/pci pci_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 May 2007 18:09:13 -0000 On Wednesday 23 May 2007 11:31:01 am Andrew Gallatin wrote: > gallatin 2007-05-23 15:31:01 UTC > > FreeBSD src repository > > Modified files: > sys/dev/pci pci_pci.c > Log: > Fix a typo in pcib_alloc_msi{x} which resulted in the > device's, not the bridge's, softc to be used to check the > PCIB_DISABLE_MSI flag. This resulted in randomly allowing > or denying MSI interrupts based on whatever value the driver > happened to store at sizeof(device_t) bytes into its softc. > > I noticed this when I stopped getting MSI interrupts > after slighly re-arranging mxge's softc yesterday. Doh, thanks for fixing! -- John Baldwin