Date: Mon, 16 Jul 2018 11:45:30 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Gerald Pfeifer <gerald@pfeifer.com> Cc: Dmitry Marakasov <amdmi3@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r470444 - head/lang/gcc-ecj45 Message-ID: <20180716094530.k6ls4yddh2nmlivd@ogg.in.absolight.net> In-Reply-To: <alpine.LSU.2.21.1807142237341.5444@anthias.pfeifer.com> References: <201805200904.w4K94BAh007929@repo.freebsd.org> <alpine.LSU.2.21.1807142237341.5444@anthias.pfeifer.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--vxfcplee3ydndkos Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jul 14, 2018 at 10:39:11PM +0200, Gerald Pfeifer wrote: > On Sun, 20 May 2018, Dmitry Marakasov wrote: > > Author: amdmi3 > > Date: Sun May 20 09:04:10 2018 > > New Revision: 470444 > > URL: https://svnweb.freebsd.org/changeset/ports/470444 > >=20 > > Log: > > - Add LICENSE > > - Cosmetic fixes > > - Add NO_ARCH > > =20 > > Approved by: portmgr blanket >=20 > I'm not really sure "cosmetic fixes" are covered by portmgr > blanket, especially where something is a style issue. >=20 > For example... >=20 > > Modified: head/lang/gcc-ecj45/Makefile > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > -EXTRACT_SUFX=3D > > -EXTRACT_ONLY=3D > > +EXTRACT_SUFX=3D # empty > > +EXTRACT_ONLY=3D # empty >=20 > ...I preferred the original version of that and do not see this > as a real improvement. There is some kind of, mmmm, style police that, I think, believe variables must have a value, so when a variable is empty, they see it as their fight to add "# empty" comments everywhere. Never understood it myself. --=20 Mathieu Arnold --vxfcplee3ydndkos Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAltMaTpfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkjXFRAAlKkOogVLqHTTNA3jJS39ERdE3zOvMlh+Pg+emhSXwHp8rQ4V+mufXlaS mtorRl5FIQA7lbUshQoFnZxocqEHmSWiUH/otTl0EDNt14TjmHZbnvor1FCpj+RM e5Hvxgmq7QRrA77mR242fjCuw3VQmdKg6GqPLs4IEvIy/jZivUPKE8+XtmHSVgC9 giu6AheXkuEqmfA/92Bg6y033t1J9cY+thu8apxlAxuY9J/zub6Q6F+ccDXDbYCE nJflsf0fnIoAp58MBDdGmJX37G86sxPYo+Cz4zun8EK2RM2lxpVxyslZngUndxI1 1mmoq6BleZHVv3Ijg0foZReBLm/1ZaSzakMVaoEmPB7CjQo51mvHCOdlt8gu8izG bgRn80lF+HAd7hPJi15bd5K7mC2pULaYP6QJJXfEW2W0UyhIzX2OWHzz+FY7U/M4 wPTTqDIoAvZZppsp2oJZ4bnBkk1iFydpkgSV3H+GR85MYnA9Z65azAlp1NJUVFHg Cdkjipaau1si3YtnyoLbTYPLQGl+cSpynoh1D/AdhjumNJnz66phygxuhmN/tasc ao32EQUksyz8MJmLLIe1vtMtJeWiwMczTAL52RTXgFQnhsQ0BhcOocVVcyN6dvtU JryASutoFDO7PVxlLvJxX5YuW8WEndtOTDGGn4CF0/KDcCbG5RU= =EaTi -----END PGP SIGNATURE----- --vxfcplee3ydndkos--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180716094530.k6ls4yddh2nmlivd>