From owner-cvs-src-old@FreeBSD.ORG Wed Jun 17 22:50:54 2009 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A0F3A1065678 for ; Wed, 17 Jun 2009 22:50:54 +0000 (UTC) (envelope-from rmacklem@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 8C99C8FC1C for ; Wed, 17 Jun 2009 22:50:54 +0000 (UTC) (envelope-from rmacklem@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n5HMosZk023478 for ; Wed, 17 Jun 2009 22:50:54 GMT (envelope-from rmacklem@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n5HMosoo023476 for cvs-src-old@freebsd.org; Wed, 17 Jun 2009 22:50:54 GMT (envelope-from rmacklem@repoman.freebsd.org) Message-Id: <200906172250.n5HMosoo023476@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to rmacklem@repoman.freebsd.org using -f From: Rick Macklem Date: Wed, 17 Jun 2009 22:50:26 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/nfsserver nfs_srvkrpc.c src/sys/nlm nlm_prot_impl.c src/sys/rpc svc.c svc_generic.c svc_vc.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jun 2009 22:50:54 -0000 rmacklem 2009-06-17 22:50:26 UTC FreeBSD src repository Modified files: sys/nfsserver nfs_srvkrpc.c sys/nlm nlm_prot_impl.c sys/rpc svc.c svc_generic.c svc_vc.c Log: SVN rev 194407 on 2009-06-17 22:50:26Z by rmacklem Since svc_[dg|vc|tli|tp]_create() did not hold a reference count on the SVCXPTR structure returned by them, it was possible for the structure to be free'd before svc_reg() had been completed using the structure. This patch acquires a reference count on the newly created structure that is returned by svc_[dg|vc|tli|tp]_create(). It also adds the appropriate SVC_RELEASE() calls to the callers, except the experimental nfs subsystem. The latter will be committed separately. Submitted by: dfr Tested by: pho Approved by: kib (mentor) Revision Changes Path 1.11 +1 -0 src/sys/nfsserver/nfs_srvkrpc.c 1.20 +5 -1 src/sys/nlm/nlm_prot_impl.c 1.7 +1 -0 src/sys/rpc/svc.c 1.4 +4 -1 src/sys/rpc/svc_generic.c 1.9 +7 -2 src/sys/rpc/svc_vc.c