From owner-freebsd-standards@FreeBSD.ORG  Wed May 21 20:12:04 2003
Return-Path: <owner-freebsd-standards@FreeBSD.ORG>
Delivered-To: freebsd-standards@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 4428237B401; Wed, 21 May 2003 20:12:04 -0700 (PDT)
Received: from espresso.bsdmike.org (espresso.bsdmike.org [65.39.129.122])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 91A5E43FAF; Wed, 21 May 2003 20:12:02 -0700 (PDT)
	(envelope-from mike@espresso.bsdmike.org)
Received: by espresso.bsdmike.org (Postfix, from userid 1002)
	id 7A3529C4C; Wed, 21 May 2003 22:56:15 -0400 (EDT)
Date: Wed, 21 May 2003 22:56:15 -0400
From: Mike Barcroft <mike@FreeBSD.org>
To: Bruce Evans <bde@zeta.org.au>
Message-ID: <20030521225615.F84644@espresso.bsdmike.org>
References: <20030314104935.GA1201@rot13.obsecurity.org>
	<20030314114123.A24654@espresso.bsdmike.org>
	<20030314170645.GE2611@rot13.obsecurity.org>
	<20030319022339.GA4946@rot13.obsecurity.org>
	<20030318213148.H72142@espresso.bsdmike.org>
	<20030327231125.GB16625@rot13.obsecurity.org>
	<20030328102807.E1826@espresso.bsdmike.org>
	<20030328222823.GD23305@rot13.obsecurity.org>
	<20030518095127.GA74158@rot13.obsecurity.org>
	<20030518202656.G19400@gamplex.bde.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030518202656.G19400@gamplex.bde.org>;
	from bde@zeta.org.au on Sun, May 18, 2003 at 08:38:24PM +1000
Organization: The FreeBSD Project
cc: standards@freebsd.org
cc: Kris Kennaway <kris@obsecurity.org>
Subject: Re: Ports broken due to -current change (Re: Ports broken on ia64)
X-BeenThere: freebsd-standards@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Standards compliance <freebsd-standards.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-standards>,
	<mailto:freebsd-standards-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-standards>
List-Post: <mailto:freebsd-standards@freebsd.org>
List-Help: <mailto:freebsd-standards-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-standards>,
	<mailto:freebsd-standards-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 22 May 2003 03:12:04 -0000

[Moved to -standards, BCC'd to -current.]

Bruce Evans <bde@zeta.org.au> writes:
> On Sun, 18 May 2003, Kris Kennaway wrote:
> > http://bento.freebsd.org/errorlogs/i386-5-latest/gnu-finger-1.37.log
> >
> > In file included from os.c:24:
> > /usr/include/sys/stat.h:168: sizeof applied to an incomplete type
> > /usr/include/sys/stat.h:169: sizeof applied to an incomplete type
> > /usr/include/sys/stat.h:168: warning: width of `((anonymous))' exceeds its type
> > /usr/include/sys/stat.h:169: warning: width of `((anonymous))' exceeds its type

>From the URL above, it looks like this program also has a problem with
<sys/file.h>.  One would assume from the output that it specifies a
standard then uses a header outside of the standard (ie <sys/file.h>).

I think in the past we've labeled these as application problems, but
perhaps we might want to be a bit more accommodating to pseudo-
conformant applications (especially considering it usually only
requires an s/u_int/unsigned int/ and s/u_int(\d+)_t/uint$1_t/ in
userland headers).

> Untested fix:
[...patch to fix __BSD_VISIBLE misuse in <sys/stat.h>...]
> 
> "find /usr/include/ | grep _VISIBLE | egrep(ifdef|ifndef|defined)"
> shows similar bugs in <math.h>.

I'm seeking commit approval to fix both of these.

Best regards,
Mike Barcroft