From owner-freebsd-current@freebsd.org Thu Aug 16 19:49:12 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5539F1074CCF for ; Thu, 16 Aug 2018 19:49:12 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id F04B676563 for ; Thu, 16 Aug 2018 19:49:11 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: by mailman.ysv.freebsd.org (Postfix) id B1F781074CCB; Thu, 16 Aug 2018 19:49:11 +0000 (UTC) Delivered-To: current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 77C041074CC9 for ; Thu, 16 Aug 2018 19:49:11 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 173657655E; Thu, 16 Aug 2018 19:49:11 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id D6C1A9DE9; Thu, 16 Aug 2018 19:49:10 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 1AA431368; Thu, 16 Aug 2018 19:49:10 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id fLziLlV0rfmN; Thu, 16 Aug 2018 19:49:07 +0000 (UTC) Subject: Re: /usr/bin/ld: error: undefined symbol: main [r337834 -> r337903] DKIM-Filter: OpenDKIM Filter v2.10.3 mail.xzibition.com 81FB01350 To: Ian Lepore , Xin LI , Brad Davis Cc: current@freebsd.org References: <20180816111532.GY1190@albert.catwhisker.org> <1534436769.312158.1476422048.77F4DB62@webmail.messagingengine.com> <1534446597.1466.42.camel@freebsd.org> From: Bryan Drewery Openpgp: preference=signencrypt Autocrypt: addr=bdrewery@FreeBSD.org; prefer-encrypt=mutual; keydata= xsBNBFJphmsBCADiFgmS4bIzwZijrS31SjEMzg+n5zNellgM+HkShwehpqCiyhXdWrvH6dTZ a6u50pbUIX7doTR7W7PQHCjCTqtpwvcj0eulZva+iHFp+XrbgSFHn+VVXgkYP2MFySyZRFab D2qqzJBEJofhpv4HvY6uQI5K99pMqKr1Z/lHqsijYYu4RH2OfwB5PinId7xeldzWEonVoCr+ rfxzO/UrgA6v/3layGZcKNHFjmc3NqoN1DXtdaEHqtjIozzbndVkH6lkFvIpIrI6i5ox8pwp VxsxLCr/4Musd5CWgHiet5kSw2SzNeA8FbxdLYCpXNVu+uBACEbCUP+CSNy3NVfEUxsBABEB AAHNJEJyeWFuIERyZXdlcnkgPGJkcmV3ZXJ5QEZyZWVCU0Qub3JnPsLAgAQTAQoAKgIbAwUL CQgHAwUVCgkICwUWAwIBAAIeAQIXgAIZAQUCWujOIgUJCmB7NwAKCRA113G7bkaXz/xpB/9b /UWIPbieY1IeIuHF2pyYPE7Hytkh3HVsxMA0F5Ma2AYQsXZZeKNKWrF7RPyDyDwUklLHJkhm k3EfClBbHxf08kMIm1vWCJRtgxic9knY/bzYGiWMpHjg3cSd1XfrYH1autYqTZAjDwIkgOjU dR//Tbn4V36sY7y2jz+kdMVWvK53U32aZqiwBbCn4DPe1wSZcUs17mV/0uZdIoGdj74B1orN A/0py5vHYo6HcbBNoaR8pKRLf5VZNRsxqGIMhTucx4SJWcHpuRBWYyvJSFzwvxdK4ZD4Yqoc kFGPVtOXktVMai9exrLvP3G77fKMu8DI6j4QRU4wCesnHuIfRPFuzsBNBFJphmsBCACiVFPf kNfaFtUSuY0395ueo/rMyHPGPQ2iwvERFCpeFGSQSgagpenNHLpFQKTg/dl6FOoST5tqyxMq fyHGHDzzU51bvA/IfaGoNi/BIhTe/toZNMRvpcI3PLjiGcnJnuwCCbAVOAGdb+t5cZtpNdOI cKYmrYG3u9RiBpe6dTF+qLrD/8Bs1wjhduQ8fcNNgnkXu8xDH4ZxY0lIc3QgvYWp9vimlQe6 iKjUd2/DX28ETZcD5h6pYV331KMPTrEI0p0yvFijUZce8c1XHFyL1j9sBAha5qpszJl6Uq5i LolhKRcGfcdmtD72vHQjUYglUyudSJUVyo2gMYjdbiFKzJulABEBAAHCwGUEGAEKAA8FAlJp hmsCGwwFCQlmAYAACgkQNddxu25Gl89UPggA2mGQp28yCUKsJ6KHFVy/lpHfoQrKF+s7HfKT U2ObVeVNX4I8ZdW1UO48mRqxEOwY8r5YSH6X06OmiqCX2aSMXg3N06/l+ztlB0+UGGlkXBjv l9/nii+bC6b8XWuu0X7Qpb9oYBK9YtoaoyuVplAmjdj/cPou65meKIaS1yDTjHh450DrW8Qg he6l0bFX4BHKTSm99U90ML7EY19B6iI2BZSqWutVsyD71oAREY6NGgDpCOIO6FS41+WeYCDR j8vsa/BiaoX2d2SBDsCwsEwe9fg5PYMi2uVIhvL6OrxnwOdB+TkgvOy5zZSNO29UG/JilZKo Ndz2wpEaUzChGGqLvcLAZQQYAQoADwIbDAUCWujOKAUJCmB7PQAKCRA113G7bkaXz6bkB/9H dUR3E0wBwMh6z0AOFDKh+PbRI9Xd4IncdhE55tNK410650a3gADIDwqz3i72GIinkgaxzpEO xP1bs7a+BeF3p5Xd6Jjk6J/nEshisgNW7VjUbJHFGs8Sf9A6oM3q4VkI/ArVo5qkZxgKs72U HSAy5NV+AdqdTrWuAL20xfQ6gA7JF35Xf8zyUM2GMl0X8ik7dJ1jMp+TB27LipqbDgamFzH9 F9hC9gur94OQ/x3nQ+mFZ1uipYHA1EdrKuhb/Ts4bN/Ezl8nmYGxc9Bw7ZBxGOTId/rEIzoe LWpAvg6dcw0T9lNfSWc6PX+kf3dOXNIdkw9NqKID8wEPe8axcGYG Organization: FreeBSD Message-ID: Date: Thu, 16 Aug 2018 12:49:06 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1534446597.1466.42.camel@freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lx8RFjRFPQNJyMUY8oCdvMyxTvcGQH44n" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Aug 2018 19:49:12 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --lx8RFjRFPQNJyMUY8oCdvMyxTvcGQH44n Content-Type: multipart/mixed; boundary="e5ZZ5HvJQvOC6ZpVEZyiwWyAtUs74K6mf"; protected-headers="v1" From: Bryan Drewery To: Ian Lepore , Xin LI , Brad Davis Cc: current@freebsd.org Message-ID: Subject: Re: /usr/bin/ld: error: undefined symbol: main [r337834 -> r337903] References: <20180816111532.GY1190@albert.catwhisker.org> <1534436769.312158.1476422048.77F4DB62@webmail.messagingengine.com> <1534446597.1466.42.camel@freebsd.org> In-Reply-To: <1534446597.1466.42.camel@freebsd.org> --e5ZZ5HvJQvOC6ZpVEZyiwWyAtUs74K6mf Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 8/16/18 12:09 PM, Ian Lepore wrote: > On Thu, 2018-08-16 at 11:25 -0700, Xin LI wrote: >> On Thu, Aug 16, 2018 at 9:26 AM Brad Davis wrote: >>> >>> >>> On Thu, Aug 16, 2018, at 10:13 AM, Xin LI wrote: >>>> >>>> This was caused by r337852, but I didn't investigated further. >>>> >>>> The problem is that we have a source file called 'moduli.c' in >>>> crypto/openssh/ while the build target was moduli, and bmake seen >>>> 'moduli' in source tree as older than moduli.c, and decided to >>>> rebuild >>>> it from source, while the two files are unrelated. >>> Hi Xin, >>> >>> I don't see how that could be the case as I didn't move the file >>> around, I just moved how it gets installed. >>> >>> I have done many many builds with this change in and haven't seen >>> this problem.. >> Yeah, let me rephrase: this might have been exposed by r337852; I >> don't think your change itself really caused or should have caused >> problem, but my theory based on what we have observed was that it >> might have exposed a bug where either bmake itself, or some .mk files >> might have generated e.g. automatic rule for ${foo}: ${foo}.c rules >> (haven't traced that part down yet). >> >=20 > There is an implicit rule to build file from file.c, it's why you can > type "make foo" in a dir that contains a foo.c and no Makefile. >=20 > The CONFS=3Dmoduli makes moduli into a target. =C2=A0The implicit rules= search > finds the rule to make moduli from moduli.c and because of the .PATH > it's able to find a moduli.c. >=20 > It might be fixable by simply adding a target with a do-nothing script > for building moduli in usr.sbin/sshd/Makefile. =C2=A0Something like >=20 > moduli: > =C2=A0 =C2=A0 @ : # Do nothing. >=20 > But that's just a wild guess on my part, not sure that'll work. Hmm, in= > fact, it'll probably cause a make warning about duplicate targets with > scripts. >=20 > --Ian >=20 >> The most scaring part is that the build system seems to trying >> building crypto/openssh/moduli because moduli.c was newer, and the >> file was deleted as part of the rebuild; should moduli.c compile by >> its own, we would end up with a binary moduli file. >> >> I'll take another look tonight if I had some time. >> >>> >>> >>> >>> Regards, >>> Brad Davis >>> >>>> >>>> On Thu, Aug 16, 2018 at 4:19 AM David Wolfskill >>> .org> wrote: >>>>> >>>>> >>>>> Running: >>>>> >>>>> FreeBSD g1-215.catwhisker.org 12.0-ALPHA1 FreeBSD 12.0-ALPHA1 >>>>> #80=C2=A0=C2=A0r337834M/337834:1200077: Wed Aug 15 04:34:45 PDT 201= 8=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 >>>>> root@g1-215.catwhisker.org:/common/S4/obj/usr/src/amd64.amd64/s >>>>> ys/CANARY=C2=A0=C2=A0amd64 >>>>> >>>>> after updating working copy to r337903, I'm seeing: >>>>> >>>>> ... >>>>>> >>>>>>> >>>>>>>> >>>>>>>> stage 4.3: building everything >>>>> ... >>>>> --- ifconfig_make --- >>>>> Building >>>>> /common/S4/obj/usr/src/amd64.amd64/rescue/rescue/usr/src/sbin/i >>>>> fconfig/af_inet6.o >>>>> --- all_subdir_secure --- >>>>> --- moduli --- >>>>> /usr/bin/ld: error: undefined symbol: main >>>>>> r337928 should fix it. --=20 Regards, Bryan Drewery --e5ZZ5HvJQvOC6ZpVEZyiwWyAtUs74K6mf-- --lx8RFjRFPQNJyMUY8oCdvMyxTvcGQH44n Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEE+Rc8ssOq6npcih8JNddxu25Gl88FAlt11TMACgkQNddxu25G l89pRgf/RTKp03Ef/5iHKsVqqMe4qKxQ6aZaPSz4Ipua0fSGfWrPEESAhKGiPccU YmkudHpBBr+U+0pu07djhWCiHLT7ixg9sR+tpiCiTG6eqF5zXxAF52G+q/RTvAx4 3vwJbuD5DpMl8k0zwzyOHXBKdOOfc3J6qhhxJ3/wKpuEAh/pHQUfv3OPTauiH/gZ LVJsSSjy1X1a08cnkVnfyArhyaRV2x9QYkSjOm0DSZduvkZ/icfzWYDLnJznRuZo QHcVg0lw1/jwkZT8yilstLf+mr7jfeEVvI6XAIpaQMIfUdTvUBfdGKlntobBBlVs kPvT0PtSzyPZ22YC0AQ9rWr10xYQfQ== =jrc6 -----END PGP SIGNATURE----- --lx8RFjRFPQNJyMUY8oCdvMyxTvcGQH44n--