From owner-cvs-all@FreeBSD.ORG Mon Jun 23 19:16:05 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1859D37B405 for ; Mon, 23 Jun 2003 19:16:05 -0700 (PDT) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 041D643FA3 for ; Mon, 23 Jun 2003 19:16:04 -0700 (PDT) (envelope-from nate@rootlabs.com) Received: (qmail 68822 invoked by uid 1000); 24 Jun 2003 02:16:05 -0000 Date: Mon, 23 Jun 2003 19:16:05 -0700 (PDT) From: Nate Lawson To: Sam Leffler In-Reply-To: <8618913.1056386895@melange.errno.com> Message-ID: <20030623191423.X68807@root.org> References: <200306232323.h5NNNnJZ092748@repoman.freebsd.org> <8618913.1056386895@melange.errno.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jun 2003 02:16:05 -0000 On Mon, 23 Jun 2003, Sam Leffler wrote: > I believe this also makes things work for bridging (and other similar > "middle ware" which may cause start to be entered directly from a recv. > However my approach to dealing with this problem in other drivers was to > use two different locks, one for the xmit side and one for the recv side. > I'm not certain what I've done handles everything but it certainly > eliminates the up-down locking per-packet that's required if you stick to > one lock. I'd be interested in hearing how you address these along with the softc lock case. For example, both tx and rcv paths need to serialize with the detach method if someone unloads a driver. I think right now I will have a race in that case since I drop the lock. -Nate