From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Feb 21 02:00:39 2005 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 03BE116A4CE for ; Mon, 21 Feb 2005 02:00:39 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id AAB6743D49 for ; Mon, 21 Feb 2005 02:00:38 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.1/8.13.1) with ESMTP id j1L20cx0026474 for ; Mon, 21 Feb 2005 02:00:38 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.1/8.13.1/Submit) id j1L20csK026473; Mon, 21 Feb 2005 02:00:38 GMT (envelope-from gnats) Resent-Date: Mon, 21 Feb 2005 02:00:38 GMT Resent-Message-Id: <200502210200.j1L20csK026473@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Sam Lawrance Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9903216A4CE for ; Mon, 21 Feb 2005 01:50:56 +0000 (GMT) Received: from bloodwood.hunterlink.net.au (smtp-local.hunterlink.net.au [203.12.144.17]) by mx1.FreeBSD.org (Postfix) with ESMTP id F119743D46 for ; Mon, 21 Feb 2005 01:50:55 +0000 (GMT) (envelope-from boris@brooknet.com.au) Received: from localhost (ppp28B6.dyn.pacific.net.au [61.8.40.182]) j1L1oqY7023426 for ; Mon, 21 Feb 2005 12:50:54 +1100 Received: by localhost (Postfix, from userid 1001) id 7891116CA; Mon, 21 Feb 2005 12:51:58 +1100 (EST) Message-Id: <20050221015158.7891116CA@localhost> Date: Mon, 21 Feb 2005 12:51:58 +1100 (EST) From: Sam Lawrance To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: ports/77820: bsd.port.mk 1.508 and PORTDOCS globbing broken X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Sam Lawrance List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Feb 2005 02:00:39 -0000 >Number: 77820 >Category: ports >Synopsis: bsd.port.mk 1.508 and PORTDOCS globbing broken >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Feb 21 02:00:37 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Sam Lawrance >Release: FreeBSD 5.3-STABLE i386 >Organization: >Environment: System: FreeBSD dirk.no.domain 5.3-STABLE FreeBSD 5.3-STABLE #3: Wed Feb 9 00:12:24 EST 2005 sam@dirk.no.domain:/usr/testbuild/src5/sys/i386/compile/GENERIC i386 >Description: The changes to bsd.port.mk 1.508 don't work as expected with globbing. PORTDOCS is supposed to allow shell glob patterns. Here's the offending code, now on line 4796: +.for x in ${PORTDOCS} + @if [ ! -e ${DOCSDIR}/${x} ]; then \ + @${ECHO_CMD} ${DOCSDIR}/${x} | \ + ${SED} -e 's,^${PREFIX}/,,' >> ${TMPPLIST}; \ + fi +.endfor The glob is expanded by the shell, so [ gets too many arguments, leading to errors like this one: [: /usr/local/share/doc/pyumlgraph/PyUMLGraph.css: unexpected operator >How-To-Repeat: Install a port with a glob in PORTDOCS and watch carefully. >Fix: Perhaps the for-loop needs to be pushed out to the shell? >Release-Note: >Audit-Trail: >Unformatted: