From owner-cvs-all Tue Nov 6 1:53:15 2001 Delivered-To: cvs-all@freebsd.org Received: from amsfep12-int.chello.nl (amsfep12-int.chello.nl [213.46.243.17]) by hub.freebsd.org (Postfix) with ESMTP id DB49F37B417; Tue, 6 Nov 2001 01:53:06 -0800 (PST) Received: from daemon.chronias.ninth-circle.org ([62.163.96.180]) by amsfep12-int.chello.nl (InterMail vM.5.01.03.06 201-253-122-118-106-20010523) with ESMTP id <20011106095305.SKNQ7460.amsfep12-int.chello.nl@daemon.chronias.ninth-circle.org>; Tue, 6 Nov 2001 10:53:05 +0100 Received: (from asmodai@localhost) by daemon.chronias.ninth-circle.org (8.11.6/8.11.6) id fA69quf05005; Tue, 6 Nov 2001 10:52:56 +0100 (CET) (envelope-from asmodai) Date: Tue, 6 Nov 2001 10:52:56 +0100 From: Jeroen Ruigrok/Asmodai To: Dag-Erling Smorgrav Cc: "Andrew R. Reiter" , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/syscons/logo logo_saver.c src/sys/dev/syscons/rain rain_saver.c src/sys/dev/syscons/warp warp_saver.c Message-ID: <20011106105256.K97551@daemon.ninth-circle.org> References: <20011106102215.J97551@daemon.ninth-circle.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.23i Organisation: Ninth-Circle Enterprises Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG -On [20011106 10:50], Dag-Erling Smorgrav (des@ofug.org) wrote: >There's nothing wrong with it. It doesn't come into the picture at >all. Ok, that's all I needed to know, it might be that you have missed sc_set_border(). >Read code first, ask questions later. If you can give me 48 hours in a day to spend time to read all the code people commit then yes, otherwise I resort to asking questions to the person who just touched the code, one could assume they are now probably more familiar with it then the person asking the question. -- Jeroen Ruigrok van der Werven / Asmodai / Kita no Mono asmodai@[wxs.nl|[freebsd|xmach].org], finger asmodai@ninth-circle.dnsalias.net http://www.freebsd.org/doc/en_US.ISO8859-1/books/developers-handbook/ I disagree with everything you say. But I will defend to the death your right to say it. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message