Date: Sat, 4 Dec 2021 18:16:42 +0000 (UTC) From: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: ad2a0aec2954 - main - nhop: hash ifnet pointer instead of if_index Message-ID: <alpine.BSF.2.00.2112041814540.68830@ai.fobar.qr> In-Reply-To: <202112041806.1B4I6HGV058876@gitrepo.freebsd.org> References: <202112041806.1B4I6HGV058876@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 4 Dec 2021, Gleb Smirnoff wrote: > The branch main has been updated by glebius: > > URL: https://cgit.FreeBSD.org/src/commit/?id=ad2a0aec295478e750158b8985422f15deee0e54 > > commit ad2a0aec295478e750158b8985422f15deee0e54 > Author: Gleb Smirnoff <glebius@FreeBSD.org> > AuthorDate: 2021-12-04 18:05:46 +0000 > Commit: Gleb Smirnoff <glebius@FreeBSD.org> > CommitDate: 2021-12-04 18:05:46 +0000 > > nhop: hash ifnet pointer instead of if_index > > Yet another problem created by VIMAGE/if_vmove/epair design that > relocates ifnet between vnets and changes if_index. Since if_index > changes, nhop hash values also changes, unlink_nhop() isn't able to > find entry in hash and leaks the nhop. Since nhop references ifnet, > the latter is also leaked. As result running network tests leaks > memory on every single test that creates vnet jail. That sounds like something (new) is done in wrong sequence for these cases. Plastering around that sounds wrong as it simply hides the real problem. -- Bjoern A. Zeeb r15:7
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.00.2112041814540.68830>