From owner-freebsd-hackers  Thu Jan 18  6:13:39 2001
Delivered-To: freebsd-hackers@freebsd.org
Received: from tao.org.uk (genesis.tao.org.uk [194.242.131.94])
	by hub.freebsd.org (Postfix) with ESMTP
	id 9AEE737B699; Thu, 18 Jan 2001 06:13:18 -0800 (PST)
Received: by tao.org.uk (Postfix, from userid 100)
	id 820463174; Thu, 18 Jan 2001 14:12:58 +0000 (GMT)
Date: Thu, 18 Jan 2001 14:12:58 +0000
From: Josef Karthauser <joe@tao.org.uk>
To: Neil Blakey-Milner <nbm@mithrandr.moria.org>
Cc: FreeBSD Current Users <hackers@FreeBSD.org>,
	Marcel Moolenaar <marcel@FreeBSD.org>
Subject: Re: Patch to fix "make buildkernel requires full obj directory" mistake
Message-ID: <20010118141258.C84497@tao.org.uk>
References: <20010118101315.A10537@rapier.smartspace.co.za>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <20010118101315.A10537@rapier.smartspace.co.za>; from nbm@mithrandr.moria.org on Thu, Jan 18, 2001 at 10:13:15AM +0200
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

On Thu, Jan 18, 2001 at 10:13:15AM +0200, Neil Blakey-Milner wrote:
> Hi,
> 
> I've kept on forgetting to apply a patch similar to this one.
> 
> "make buildkernel" currently fails if a "make buildworld" has not
> previously been done on the machine (and still has the populated object
> environment) because OBJFORMAT_PATH is explicitly set to only use
> ${WORLDTMP}/usr/libexec.  At least for the kernel build phase, this may
> be an error, since we already use 'gcc', 'ld', and friends from $PATH.
> 
> Anyway, the attached patch fixes at least buildkernel in the way most
> obvious to me, but I'm sure there may be a more useful place to place
> the addition of OBJFORMAT_PATH, since $PATH is made to include the
> supplied $PATH environment variable in many other places.  I'm not
> willing to make a judgement whether using the supplied OBJFORMAT_PATH is
> correct in any of those places, but I wish to fix the buildkernel
> target.

Hear hear.  We had to back out the 'make buildkernel' within PicoBSD
because there was no guarentee that the user had ever done a make
buildworld.  Additionally if you do an
	env MAKEOBJDIRPREFIX=/usr/myobj make buildkernel
you have the same problem even if someone did do a make buildworld.

Joe


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message