From owner-dev-commits-ports-main@freebsd.org Sun May 9 22:44:50 2021 Return-Path: Delivered-To: dev-commits-ports-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6B6C8644BA1; Sun, 9 May 2021 22:44:50 +0000 (UTC) (envelope-from adridg@freebsd.org) Received: from lb3-smtp-cloud7.xs4all.net (lb3-smtp-cloud7.xs4all.net [194.109.24.31]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.xs4all.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FdfQB0N8Kz4T35; Sun, 9 May 2021 22:44:49 +0000 (UTC) (envelope-from adridg@freebsd.org) Received: from cust-d4a83f22 ([IPv6:fc0c:c11d:cecc:f58a:eaa1:c0:9d8f:c143]) by smtp-cloud7.xs4all.net with ESMTPA id fsAHlOQUzyEWwfsAJlEZDB; Mon, 10 May 2021 00:44:47 +0200 From: Adriaan de Groot To: "Matthew D. Fuller" Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 1c31059e3d12 - main - x11-wm/twm: generate synthetic WM hints when needed Date: Mon, 10 May 2021 00:44:45 +0200 Message-ID: <5586518.Zv9zXsTiuT@beastie.bionicmutton.org> Organization: FreeBSD In-Reply-To: References: <202105042311.144NB1gG091594@gitrepo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2549632.TYJnH3iKXO"; micalg="pgp-sha256"; protocol="application/pgp-signature" X-CMAE-Envelope: MS4xfMZ+3E4xm5q7TIUOd+1ut8yz9KA89OuQ8f6bCnMA4DLbdhNtP7hAhlXrwIIgE3kqNWz9ov1q4xclSPj0d+JCJHLFo0ujCIPyZsKGrEQ3krm7k6rMkot2 XwyV0nHs/yKrt/gXBDlvDTCmN+L5+id5MMqAp5nKwGHy1UqjSL8kXS5M70JICyQKZXOfRL6v26AvSPVQFy4cvqxJqJ5DQh+I6R8vxuxvgjglWrSCgrnnxW4R Mmp3g8/mRfIPmQQyOpzesmu2L43V8kM9K1bgcVnqGSS/g4IBPlyOQkk2QHT+xVkGP0g2sTrQJD6AWVHYh5J3PVWZF/bxOelE85OPUwifvgJoU0tlepHgI+KQ VaipKnB3LElu1FEEQlFH7H7XQ1iLgh2CVHYNrvXAqorV86phCw0= X-Rspamd-Queue-Id: 4FdfQB0N8Kz4T35 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-ports-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commits to the main branch of the FreeBSD ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 May 2021 22:44:50 -0000 --nextPart2549632.TYJnH3iKXO Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8"; protected-headers="v1" From: Adriaan de Groot To: "Matthew D. Fuller" Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 1c31059e3d12 - main - x11-wm/twm: generate synthetic WM hints when needed Date: Mon, 10 May 2021 00:44:45 +0200 Message-ID: <5586518.Zv9zXsTiuT@beastie.bionicmutton.org> Organization: FreeBSD In-Reply-To: References: <202105042311.144NB1gG091594@gitrepo.freebsd.org> On Sunday, 9 May 2021 23:08:13 CEST Matthew D. Fuller wrote: > > This is based on a patch from Reddit > > For anybody researching, this presumably comes from the vtwm patch > > https://sourceforge.net/p/vtwm/code/ci/f50508e8b71d6d874229ad3273cf821307d61 > 94b/ > > which was a cut-down version of the ctwm fix > > https://bazaar.launchpad.net/~ctwm/ctwm/trunk/revision/558 > > > (eventually things work their way upstream ;) Hey, upstream! Yes, that looks mighty familiar. I did cut it down some more (I agree with your r558 about dropping now-unnecessary checks for a NULL wmhints, but frankly the less time I spend looking at C code, the better for me). I'm a bit confused by the "XXX Revisit?" comment and then lines 349-351, which set wmhints->input=True .. something that that "revisit" line has already done unconditionally. Anyway, let's just hope for a new twm release this century that picks this up, so that you can run Chromium (why?) in twm (that trusty fallback). I'll add the upstream reference to the patch. [ade] --nextPart2549632.TYJnH3iKXO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQGzBAABCAAdFiEEhrjttu2OP5apuuy1z93JbxKxkVwFAmCYZd0ACgkQz93JbxKx kVxwPQv/cRX85uIHp65Aqf9MfdU6We44EpoasN/fPcdKv6WuDupPp2m8/eel4al3 Pi6zYfnHFrtwnkxwiy5CqO7tN7+m0qgRBTq2438qlEfAYN2MLjzVRqFxHmJ86Rtt B1uepIUiQ9xzqUiE+8BXiWScDikIUxhOikJaI3tVffWtdyr65eNLuvlMLMhSFDdC cbCFUAbyf0L666So2jP+IfuIstxKxlKEEb19lRsU63DzdVPEW3NxR5o9U8O2EBcv jhltrH5nMKP94QFCcC1fkophFcKYESCiKsZ4dx2KwPTWAUjesB/lI25wNe/83tVc 1cXpoJEEnEZab9ANgMEpSKfGu+xy+ligVsGK6TOmFJnm+Z2V+zHpz12lorE5Bdah hd9IVb3kMrqXAsdiVtKHIbqfaWwteNcALDBsZdyylnUq/9yJclbj6AxcO+WzqYNy AYsUhghianFcKeYb8da5pPA4yodDeSdbSKo389BbYBfdS4LG97c+5/hzifgOJkbW 5i2FJfsC =NHxk -----END PGP SIGNATURE----- --nextPart2549632.TYJnH3iKXO--