From owner-freebsd-ports@freebsd.org Fri Jul 22 20:27:53 2016 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 67F85BA2E6F for ; Fri, 22 Jul 2016 20:27:53 +0000 (UTC) (envelope-from russ.haley@gmail.com) Received: from mail-pa0-x242.google.com (mail-pa0-x242.google.com [IPv6:2607:f8b0:400e:c03::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id F1DE21735 for ; Fri, 22 Jul 2016 20:27:52 +0000 (UTC) (envelope-from russ.haley@gmail.com) Received: by mail-pa0-x242.google.com with SMTP id hh10so7483744pac.1 for ; Fri, 22 Jul 2016 13:27:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:content-transfer-encoding:message-id:date:subject:from :in-reply-to:references:to:cc; bh=GBwOIiMlQDqVJzKullhJ8Z7Ofx2kw9yxGrIdBHJNSxs=; b=Jd4/OOoylArKQWijRFeCCpMPj80o7GtenTdRFLGU99TH7ULUag5TWFn2sjn+WBSVXG ZHcVhFPsMklRYj8AC7VH4cBKq+0YpzhWbUDHMyKtEAow2WOQd68u8/2TDTt5fKtH55Mh LPYox4E49lWNQHYgr8ItV2HTGU7MICgU1h4Rr6FV7VcJCHFPWM5Ul4ablBuCffIwlUHz F/ZgEbcQGlIWW+UZkVkvjcSc+203W62MnNv6Lbr/pSCLcdwnFxkQ8m0Zkb3x82j4lPu0 k3qmMxndckS2l7hJT1mebax6h1XZhO9pKj9xVH9s/sKhTXLtGtpZ5j+Z+Wg76k5aTU8x l/pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:content-transfer-encoding :message-id:date:subject:from:in-reply-to:references:to:cc; bh=GBwOIiMlQDqVJzKullhJ8Z7Ofx2kw9yxGrIdBHJNSxs=; b=FdKOgMbFtJUrkNgTMF830dWa5F86fUi9DXgLyylN9hrFrW0zoRGJY8QfDy464tJO4W qstvs70CaLBeR/fRsk23nXSM8eGPj0gtwZWsRcym6gJGrXI81t3dnUw1rnuw0940/jlA PWZhzu77bsuY4z4gLwuvR2Tw+sENUMrCNkRIMUslZwaq1IzaO2Rks6yogEij+0+kD3+4 vTmiEvLItqICMKFKHIbnyOOhF2AF5hmsR0Y/X/QCw5Qcd5YGosDVPNf9nRtaYtOozY7n T89/55RW7Ml9i+i9YmLHv0f+HDPkTYzEcggaYjJHlp6xGlDo4IsxHzkXaBGs1FSUnmjD mi/w== X-Gm-Message-State: AEkoouslT5yYGdTnH3ydItvEVEZnjSfBxdtWQoOy+60K4zQrdCTFnqeVDSWP0rdMVtsPPQ== X-Received: by 10.66.43.234 with SMTP id z10mr9504330pal.137.1469219271666; Fri, 22 Jul 2016 13:27:51 -0700 (PDT) Received: from [127.0.0.1] (69-11-46-165.yktn.hsdb.sasknet.sk.ca. [69.11.46.165]) by smtp.gmail.com with ESMTPSA id t80sm21973956pfj.38.2016.07.22.13.27.50 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 22 Jul 2016 13:27:50 -0700 (PDT) Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: BlackBerry Email (10.3.2.2876) Message-ID: <20160722202750.4894802.64998.8848@gmail.com> Date: Fri, 22 Jul 2016 14:27:50 -0600 Subject: Re: Passing target to source Makefile From: Russell Haley In-Reply-To: <37n2-9hp4-wny@vfemail.net> References: <3b9c2f92-ef57-3e06-c110-8148dce16ba5@gmx.de> <37n2-9hp4-wny@vfemail.net> To: Jan Beich Cc: olli hauer , freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jul 2016 20:27:53 -0000 Sorry for the top post. Thank you for taking the time to clarify.=A0 Russ Sent=A0from=A0my=A0BlackBerry=A010=A0smartphone=A0on=A0the=A0Koodo=A0networ= k. =A0 Original Message =A0 From: Jan Beich Sent: Friday, July 22, 2016 2:54 AM To: Russell Haley Cc: olli hauer; freebsd-ports@freebsd.org Subject: Re: Passing target to source Makefile Russell Haley writes: > 1) It does not use the recommended "freebsd" target. While the port > overlays many of the same options, the system doesn't seem to respect > the targets and also performs the installation without specifically > calling the "install" target. Try adding ALL_TARGET=3Dfreebsd. INSTALL_TARGET already defaults to "install" and then the port appends extra steps via post-install. $ make -V ALL_TARGET -C lang/lua53 all > The current supported version of Lua is 5.3. While I can see the need > to install past versions using explicit naming, it is my opinion that > the current version should be installed as Lua, not luaXX. Say, a port looks for Lua 5.1 headers. If Lua 5.3 is installed without suffix the port may find wrong headers first. And fixing include order isn't always trivial with complex build systems. But -isystem as used by USES=3Dlocalbase partially alleviates that. > 4) The current Makefile applies -fPIC to some of the platforms, but > not armv6. https://svnweb.freebsd.org/changeset/ports/409263 > - Update to the latest Lua revision Do you mean Mk/bsd.default-versions.mk? lang/lua53 is already at 5.3.3. > - Use clang and bmake instead of forcing gcc/gmake. bmake isn't available on FreeBSD 9.3-RELEASE which isn't going to be EOL'd until the next year. If you mean devel/bmake then I don't see the benefit compared to devel/gmake - both are extra dependencies. Also see https://svnweb.freebsd.org/changeset/ports/285048 > Please also note that I have made an upstream request to the Lua > community to consider applying a patch to the freebsd target in their > source/Makefile. The patch can be found here: > http://pastebin.com/cUCtWb1w. I don't expect this to happen quickly > however. "freebsd" target is only slightly different from "linux" one. There's no support to build shared library upstream, so -fPIC isn't required unless you need to link liblua.a into another shared library.