From owner-svn-src-head@FreeBSD.ORG  Tue Aug 10 18:33:49 2010
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 886731065677;
	Tue, 10 Aug 2010 18:33:49 +0000 (UTC)
	(envelope-from phk@critter.freebsd.dk)
Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222])
	by mx1.freebsd.org (Postfix) with ESMTP id 479A78FC24;
	Tue, 10 Aug 2010 18:33:48 +0000 (UTC)
Received: from critter.freebsd.dk (critter.freebsd.dk [192.168.61.3])
	by phk.freebsd.dk (Postfix) with ESMTP id 0317E3F5B3;
	Tue, 10 Aug 2010 18:15:45 +0000 (UTC)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.14.4/8.14.4) with ESMTP id o7AIFiTQ011607;
	Tue, 10 Aug 2010 18:15:45 GMT (envelope-from phk@critter.freebsd.dk)
To: "M. Warner Losh" <imp@bsdimp.com>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Tue, 10 Aug 2010 11:54:57 CST."
	<20100810.115457.1126759349893144516.imp@bsdimp.com> 
Date: Tue, 10 Aug 2010 18:15:44 +0000
Message-ID: <11606.1281464144@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
Cc: src-committers@FreeBSD.org, jilles@stack.nl, svn-src-all@FreeBSD.org,
	hrs@FreeBSD.org, olli@fromme.com, olli@FreeBSD.org,
	svn-src-head@FreeBSD.org, des@des.no
Subject: Re: svn commit: r211023 - head/usr.sbin/syslogd 
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Aug 2010 18:33:49 -0000

In message <20100810.115457.1126759349893144516.imp@bsdimp.com>, "M. Warner Los
h" writes:
>In message: <20100811.023235.13138059.hrs@allbsd.org>
>            Hiroki Sato <hrs@FreeBSD.org> writes:
>: Oliver Fromme <olli@fromme.com> wrote
>:   in <201008101623.o7AGNs7I042679@haluter.fromme.com>:
>: 
>: ol> -static int	validate(struct sockaddr *, const char *);
>: ol> -static void	unmapped(struct sockaddr *);
>: ol> +static int	validate(struct sockaddr_storage *, const char *);
>: ol> +static void	unmapped(struct sockaddr_storage *);
>: 
>:  Why is s/struct sockaddr */struct sockaddr_storage */ needed here?
>:  Using (struct sockaddr *) as an argument looks reasonable to me since
>:  the struct sockaddr_storage is mostly for memory allocation, not for
>:  access via pointer.
>
>Because struct sockaddr * has a too loose alignment requirement for
>later casting, while sockaddr_storage has the proper alignment.

This is the kind of detail Bruce, Warner and I know, but I bet it
was news to most of you.

Somebody should add it to the relevant manualpages...

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.