From owner-svn-src-all@freebsd.org Sun Sep 27 16:15:03 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B88BE3FFF13; Sun, 27 Sep 2020 16:15:03 +0000 (UTC) (envelope-from mmel@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BzrMq4S7sz3gX5; Sun, 27 Sep 2020 16:15:03 +0000 (UTC) (envelope-from mmel@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 7C509F154; Sun, 27 Sep 2020 16:15:03 +0000 (UTC) (envelope-from mmel@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id 08RGF3Ll016225; Sun, 27 Sep 2020 16:15:03 GMT (envelope-from mmel@FreeBSD.org) Received: (from mmel@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id 08RGF3mE016224; Sun, 27 Sep 2020 16:15:03 GMT (envelope-from mmel@FreeBSD.org) Message-Id: <202009271615.08RGF3mE016224@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: mmel set sender to mmel@FreeBSD.org using -f From: Michal Meloun Date: Sun, 27 Sep 2020 16:15:03 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r366200 - head/sys/arm64/qoriq/clk X-SVN-Group: head X-SVN-Commit-Author: mmel X-SVN-Commit-Paths: head/sys/arm64/qoriq/clk X-SVN-Commit-Revision: 366200 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Sep 2020 16:15:03 -0000 Author: mmel Date: Sun Sep 27 16:15:03 2020 New Revision: 366200 URL: https://svnweb.freebsd.org/changeset/base/366200 Log: Check the result of the function, not the pointer to it. Modified: head/sys/arm64/qoriq/clk/qoriq_clkgen.c Modified: head/sys/arm64/qoriq/clk/qoriq_clkgen.c ============================================================================== --- head/sys/arm64/qoriq/clk/qoriq_clkgen.c Sun Sep 27 13:32:02 2020 (r366199) +++ head/sys/arm64/qoriq/clk/qoriq_clkgen.c Sun Sep 27 16:15:03 2020 (r366200) @@ -83,7 +83,7 @@ qoriq_clkgen_ofw_mapper(struct clkdom *clkdom, uint32_ *clk = clknode_find_by_id(clkdom, QORIQ_CLK_ID(cells[0], cells[1])); - if (clk == NULL) + if (*clk == NULL) return (EINVAL); return (0);