From owner-svn-src-all@FreeBSD.ORG Mon Jan 6 15:10:16 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7468ADF3; Mon, 6 Jan 2014 15:10:16 +0000 (UTC) Received: from mail-ie0-x22f.google.com (mail-ie0-x22f.google.com [IPv6:2607:f8b0:4001:c03::22f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 2356218FB; Mon, 6 Jan 2014 15:10:16 +0000 (UTC) Received: by mail-ie0-f175.google.com with SMTP id x13so18719491ief.34 for ; Mon, 06 Jan 2014 07:10:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=XjlsBqLDBj/qo/6q+i8VY3/YFgSRaCtgCFWWBsUT4Z0=; b=h+mH8RSbgEHK7TCS5RYZVugbGOIZgirvuNH/tVvnXun0q4qzX8/DfXUxiEglq1m7K+ dNRpnfj5ibl42dJuDwAWHu2RvyH9VkBqzdp6i0Nvc1dh4K7J4kbUhW3Hmrjzu0Fi0UmJ 0AN43hKWgTj2vgLewgFAkQ4Hd9VbUy0fsi5F9fwedWrqJHKBp8/WWmKtiMjrmXQcjh1y FPgZcBIYWwM0BztHDviXBe4qG7HDjvp3ZYya3+lgGanSEJCgcCwPdpBnxhIPScYuGCLj Uu58qlw3KkTDn+MStWD6EhX+n1ach5rc5Ykz6UjpLrdtsjCXiCZi7Sn22boONfiQ2Lm5 vThg== X-Received: by 10.50.143.10 with SMTP id sa10mr19788820igb.8.1389021015464; Mon, 06 Jan 2014 07:10:15 -0800 (PST) MIME-Version: 1.0 Sender: mr.kodiak@gmail.com Received: by 10.64.6.134 with HTTP; Mon, 6 Jan 2014 07:09:45 -0800 (PST) In-Reply-To: <20140106065314.GB1372@michelle.cdnetworks.com> References: <201401031103.s03B3CAf013123@svn.freebsd.org> <20140106065314.GB1372@michelle.cdnetworks.com> From: Bryan Venteicher Date: Mon, 6 Jan 2014 09:09:45 -0600 X-Google-Sender-Auth: HqBqF-8DyLBR7RPmQprPoKsKFgk Message-ID: Subject: Re: svn commit: r260224 - head/sys/netinet To: pyunyh@gmail.com Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.17 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Gleb Smirnoff , src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jan 2014 15:10:16 -0000 On Mon, Jan 6, 2014 at 12:53 AM, Yonghyeon PYUN wrote: > On Fri, Jan 03, 2014 at 11:03:12AM +0000, Gleb Smirnoff wrote: > > Author: glebius > > Date: Fri Jan 3 11:03:12 2014 > > New Revision: 260224 > > URL: http://svnweb.freebsd.org/changeset/base/260224 > > > > Log: > > Make failure of ifpromisc() a non-fatal error. This makes it possible > to > > run carp(4) on vtnet(4). > > > > vtnet(4) is the only device that doesn't correctly support > promiscuous mode? I don't know details of vtnet(4) but it seems > it's not hard to mimic promiscuous mode. I'm not sure why the > driver returns ENOTSUP to user land given that vtnet(4) defaults > to promiscuous mode for backwards compatibility. It also does > not handle multicast filter configuration when VTNET_FLAG_CTRL_RX > flag is not set. If vtnet(4) does not support multicast filter, > it shouldn't announce IFF_MULTICAST. I wonder how vtnet(4) can work > with carp(4) given that its multicast handling is ignored. > I've talked to Gleb off-list about this. I intent to remove the default to promiscuous mode hack. Previous versions of the specification had a footnote about this, but it has since been removed. Note that both promisc and multicast likely require some host configuration on the tap/bridge/physical interfaces as well. I'll look at the multicast handling. If carp(4) already works with bhyve, we might want to add a minimalist control virtqueue support to bhyve.