From owner-freebsd-bugs@FreeBSD.ORG Thu Jun 16 15:40:12 2005 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DA9D216A41C for ; Thu, 16 Jun 2005 15:40:12 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9C3FD43D5C for ; Thu, 16 Jun 2005 15:40:12 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j5GFeC0p090630 for ; Thu, 16 Jun 2005 15:40:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j5GFeCkc090629; Thu, 16 Jun 2005 15:40:12 GMT (envelope-from gnats) Resent-Date: Thu, 16 Jun 2005 15:40:12 GMT Resent-Message-Id: <200506161540.j5GFeCkc090629@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Ted Faber Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2D53916A41C for ; Thu, 16 Jun 2005 15:37:17 +0000 (GMT) (envelope-from faber@pun.isi.edu) Received: from pun.isi.edu (pun.isi.edu [128.9.160.150]) by mx1.FreeBSD.org (Postfix) with ESMTP id 15B7C43D1D for ; Thu, 16 Jun 2005 15:37:17 +0000 (GMT) (envelope-from faber@pun.isi.edu) Received: from pun.isi.edu (localhost [127.0.0.1]) by pun.isi.edu (8.13.3/8.13.1) with ESMTP id j5GFbGjw096451; Thu, 16 Jun 2005 08:37:16 -0700 (PDT) (envelope-from faber@pun.isi.edu) Received: (from faber@localhost) by pun.isi.edu (8.13.3/8.13.1/Submit) id j5GFbGEA096450; Thu, 16 Jun 2005 08:37:16 -0700 (PDT) (envelope-from faber) Message-Id: <200506161537.j5GFbGEA096450@pun.isi.edu> Date: Thu, 16 Jun 2005 08:37:16 -0700 (PDT) From: Ted Faber To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Ted Faber Subject: bin/82325: chkgrp flags NIS domains as containing illegal chars (patch incl) X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Ted Faber List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jun 2005 15:40:13 -0000 >Number: 82325 >Category: bin >Synopsis: chkgrp flags NIS domains as containing illegal chars (patch incl) >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Thu Jun 16 15:40:12 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Ted Faber >Release: FreeBSD 6.0-CURRENT i386 >Organization: USC/ISI >Environment: System: FreeBSD pun.isi.edu 6.0-CURRENT FreeBSD 6.0-CURRENT #7: Tue May 31 10:01:48 PDT 2005 root@pun.isi.edu:/usr/obj/usr/src/sys/PUN i386 >Description: A group that like +div7 which is teh div7 group imported by NIS triggers a message like: chkgrp: /etc/group: line 285: '+' invalid character >How-To-Repeat: Run chkgrp on such a groups file >Fix: patch: --- chkgrp.c.orig Wed Jun 15 08:04:27 2005 +++ chkgrp.c Wed Jun 15 08:13:07 2005 @@ -105,7 +105,23 @@ line[i++] = 0; } - for (cp = f[0] ; *cp ; cp++) { + /* + * A group with the first character '+' is an NIS group. Allow that + * case explicitly. + */ + cp = f[0]; + if (!isalnum(*cp) && *cp != '.' && *cp != '+' && *cp != '_' && + *cp != '-') { + warnx("%s: line %d: '%c' invalid character", gfn, n, *cp); + e++; + } + cp++; + + /* + * Check second through last characters of the group name for bad + * characters (cp is not re-initialized). + */ + for ( ; *cp ; cp++) { if (!isalnum(*cp) && *cp != '.' && *cp != '_' && *cp != '-') { warnx("%s: line %d: '%c' invalid character", gfn, n, *cp); e++; >Release-Note: >Audit-Trail: >Unformatted: