From owner-svn-src-head@FreeBSD.ORG Sun Oct 13 09:50:21 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 7500A5D1; Sun, 13 Oct 2013 09:50:21 +0000 (UTC) (envelope-from mark@grondar.org) Received: from gromit.grondar.org (grandfather.grondar.org [IPv6:2a01:348:0:15:5d59:5c20:0:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 391522B52; Sun, 13 Oct 2013 09:50:21 +0000 (UTC) Received: from graveyard.grondar.org ([88.96.155.33] helo=gronkulator.grondar.org) by gromit.grondar.org with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.80.1 (FreeBSD)) (envelope-from ) id 1VVIJW-000KD3-6u; Sun, 13 Oct 2013 10:50:19 +0100 Subject: Re: svn commit: r256377 - in head: etc/defaults etc/rc.d share/examples/kld/random_adaptor share/man/man4 sys/boot/forth sys/conf sys/dev/glxsb sys/dev/hifn sys/dev/random sys/dev/rndtest sys/dev/safe ... Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\)) Content-Type: multipart/signed; boundary="Apple-Mail=_17F46C5F-3696-4698-A195-29B6F82D0ACD"; protocol="application/pgp-signature"; micalg=pgp-sha512 From: Mark R V Murray In-Reply-To: <20131013074825.GO41229@kib.kiev.ua> Date: Sun, 13 Oct 2013 10:50:17 +0100 Message-Id: <3B77143C-7D82-4E62-9974-BC2C6846893F@grondar.org> References: <201310121257.r9CCvvjO006546@svn.freebsd.org> <20131013074825.GO41229@kib.kiev.ua> To: Konstantin Belousov X-Mailer: Apple Mail (2.1510) X-SA-Score: -2.2 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Mark Murray X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Oct 2013 09:50:21 -0000 --Apple-Mail=_17F46C5F-3696-4698-A195-29B6F82D0ACD Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On 13 Oct 2013, at 08:48, Konstantin Belousov wrote: > On Sat, Oct 12, 2013 at 12:57:57PM +0000, Mark Murray wrote: >> Author: markm >> Date: Sat Oct 12 12:57:57 2013 >> New Revision: 256377 >> URL: http://svnweb.freebsd.org/changeset/base/256377 >> >> Log: >> Merge from project branch. Uninteresting commits are trimmed. >> >> Refactor of /dev/random device. Main points include: > > The random.ko is broken. On boot, I get > link_elf_obj: symbol live_entropy_source_deregister undefined > KLD file random.ko - could not finalize loading > > There are several files from dev/random which are listed as > 'optional random' in conf/files but are not added to the SRCS in > modules/random/Makefile. I do not know the intent of splitting the > dev/random into the module and non-optional part of the kernel, so > cannot provide the patch. > > Please fix. Here's the fix: Index: sys/modules/random/Makefile =================================================================== --- sys/modules/random/Makefile (revision 256427) +++ sys/modules/random/Makefile (working copy) @@ -10,7 +10,8 @@ SRCS+= nehemiah.c SRCS+= ivy.c .endif -SRCS+= randomdev_soft.c yarrow.c hash.c +SRCS+= randomdev_soft.c random_harvestq.c live_entropy_sources.c +SRCS+= yarrow.c hash.c rwfile.c SRCS+= rijndael-alg-fst.c rijndael-api-fst.c sha2.c SRCS+= bus_if.h device_if.h vnode_if.h opt_cpu.h opt_random.h M -- Mark R V Murray --Apple-Mail=_17F46C5F-3696-4698-A195-29B6F82D0ACD Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.20 (Darwin) Comment: GPGTools - http://gpgtools.org iQCVAwUBUlps2d58vKOKE6LNAQqrxgP/Qcg3u09jSqOd1uUHh9gU3Yi8wU0aSjmY nZ/6kuzvGRHvMg5mozZwp59dWe38GTorMp91Yh9TjPwdVFKY80W3naT6AMXmGY5Z ojntyXYjPobgWVsIYLm3UC1n8XayjUjMjVITpgOMsvlpss9aw19iqAY2v72l52bQ 7nuMh2fdY+k= =pdg8 -----END PGP SIGNATURE----- --Apple-Mail=_17F46C5F-3696-4698-A195-29B6F82D0ACD--