From owner-cvs-all@FreeBSD.ORG Mon Jan 29 18:07:34 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6F94216A400 for ; Mon, 29 Jan 2007 18:07:34 +0000 (UTC) (envelope-from nate@root.org) Received: from root.org (root.org [67.118.192.226]) by mx1.freebsd.org (Postfix) with ESMTP id 4534513C428 for ; Mon, 29 Jan 2007 18:07:34 +0000 (UTC) (envelope-from nate@root.org) Received: (qmail 37071 invoked from network); 29 Jan 2007 18:07:34 -0000 Received: from ppp-71-139-39-138.dsl.snfc21.pacbell.net (HELO ?10.0.5.59?) (nate-mail@71.139.39.138) by root.org with ESMTPA; 29 Jan 2007 18:07:34 -0000 Message-ID: <45BE37DC.6080509@root.org> Date: Mon, 29 Jan 2007 10:07:24 -0800 From: Nate Lawson User-Agent: Thunderbird 1.5.0.9 (Windows/20061207) MIME-Version: 1.0 To: Pawel Jakub Dawidek References: <20070128202917.5B67916A5A6@hub.freebsd.org> <45BD82D2.20301@root.org> <20070129175222.GA87767@garage.freebsd.pl> In-Reply-To: <20070129175222.GA87767@garage.freebsd.pl> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/geom/eli g_eli.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jan 2007 18:07:34 -0000 Pawel Jakub Dawidek wrote: > On Sun, Jan 28, 2007 at 09:14:58PM -0800, Nate Lawson wrote: >> Pawel Jakub Dawidek wrote: >>> pjd 2007-01-28 20:29:12 UTC >>> FreeBSD src repository >>> Modified files: >>> sys/geom/eli g_eli.c Log: >>> It is possible that GEOM taste provider before SMP is started. >>> We can't bind to a CPU which is not yet on-line, so add code that wait for >>> CPUs to go on-line before binding to them. >>> Reported by: Alin-Adrian Anton >>> MFC after: 2 weeks >>> Revision Changes Path >>> 1.34 +7 -0 src/sys/geom/eli/g_eli.c >>> Index: src/sys/geom/eli/g_eli.c >>> diff -u src/sys/geom/eli/g_eli.c:1.33 src/sys/geom/eli/g_eli.c:1.34 >>> --- src/sys/geom/eli/g_eli.c:1.33 Thu Nov 2 09:01:34 2006 >>> +++ src/sys/geom/eli/g_eli.c Sun Jan 28 20:29:12 2007 >>> @@ -324,6 +324,13 @@ >>> wr = arg; >>> sc = wr->w_softc; >>> +#ifdef SMP >>> + /* Before sched_bind() to a CPU, wait for all CPUs to go on-line. */ >>> + if (sc->sc_crypto == G_ELI_CRYPTO_SW && g_eli_threads == 0) { >>> + while (!smp_started) >>> + tsleep(wr, 0, "geli:smp", hz / 4); >>> + } >>> +#endif >>> mtx_lock_spin(&sched_lock); >>> sched_prio(curthread, PRIBIO); >>> if (sc->sc_crypto == G_ELI_CRYPTO_SW && g_eli_threads == 0) >> I thought tsleep() didn't work right before !cold. Is that old knowledge? > > Hmm, I thought that cold is zeroed before smp_started is set? > I don't think that's guaranteed. Besides, there's an easier way to fix your problem. Instead of calling kthread_create() from your geom create routine directly, queue a stub request on the thread taskqueue to call kthread_create(). For example, see sys/dev/acpica/acpi_acad.c. We call this from attach() and then the system thread only runs and then calls acpi_acad_init() once all CPUs are initialized. See sys/sys/taskqueue.h for how to add a task to the system thread taskqueue: taskqueue_enqueue(taskqueue_thread, &task); -- Nate