From owner-freebsd-hackers Thu Jun 20 16:29:39 2002 Delivered-To: freebsd-hackers@freebsd.org Received: from mta7.pltn13.pbi.net (mta7.pltn13.pbi.net [64.164.98.8]) by hub.freebsd.org (Postfix) with ESMTP id 77D8937B412; Thu, 20 Jun 2002 16:29:33 -0700 (PDT) Received: from kokeb.ambesa.net ([66.122.213.147]) by mta7.pltn13.pbi.net (iPlanet Messaging Server 5.1 (built May 7 2001)) with ESMTP id <0GY100EG82L8XU@mta7.pltn13.pbi.net>; Thu, 20 Jun 2002 16:29:33 -0700 (PDT) Received: from kokeb.ambesa.net (tanstaafl@localhost [127.0.0.1]) by kokeb.ambesa.net (8.12.3/8.12.3) with ESMTP id g5KNYfeU041592; Thu, 20 Jun 2002 16:34:41 -0700 (PDT envelope-from mikem@kokeb.ambesa.net) Received: (from mikem@localhost) by kokeb.ambesa.net (8.12.3/8.12.3/Submit) id g5KNYfIb041591; Thu, 20 Jun 2002 16:34:41 -0700 (PDT envelope-from mikem) Date: Thu, 20 Jun 2002 16:34:41 -0700 From: Mike Makonnen Subject: Re: fdcheckstd() test bug in execve() (was: Re: Suggested fixes for uidinfo "would sleep" messages) In-reply-to: <200206200704.g5K74OM1068558@gw.catspoiler.org> To: Don Lewis Cc: bright@mu.org, jhb@FreeBSD.ORG, hackers@FreeBSD.ORG Message-id: <20020620163441.5f204b3f.makonnen@pacbell.net> MIME-version: 1.0 X-Mailer: Sylpheed version 0.7.0 (GTK+ 1.2.10; i386--freebsd5.0) Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7BIT References: <20020619191846.4aa74dd6.makonnen@pacbell.net> <200206200704.g5K74OM1068558@gw.catspoiler.org> Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, 20 Jun 2002 00:04:41 -0700 (PDT) Don Lewis wrote: > > Your patch also looks like it should fix the bug. I prefer my patch, > though, because I think the resultant code is structured better and > should be easier to understand. For instance, the reason for the > assignment to oldcred in the "if (error != 0)" block in your patch is > not immediately obvious. You can remove it, it was part of something else I was working on. I haven't taken a look at your patch. I was working on something else and already had a patch for it, before I saw yours. I sent it as a reference because there was something in the thread about leaking p_args. I really don't care which patch makes it into the tree. If it solves the problem, it solves the problem. There's not much more to it. Cheers, Mike Makonnen To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message