From owner-svn-src-all@FreeBSD.ORG  Mon Oct 15 23:26:22 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 69CD62F7;
 Mon, 15 Oct 2012 23:26:22 +0000 (UTC)
 (envelope-from adrian.chadd@gmail.com)
Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com
 [209.85.160.54])
 by mx1.freebsd.org (Postfix) with ESMTP id BE5B18FC0A;
 Mon, 15 Oct 2012 23:26:21 +0000 (UTC)
Received: by mail-pb0-f54.google.com with SMTP id rp8so5771733pbb.13
 for <multiple recipients>; Mon, 15 Oct 2012 16:26:21 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date
 :x-google-sender-auth:message-id:subject:from:to:cc:content-type;
 bh=8UpvucirNALRI7J975XwJda9TG5rXOlGRJtfGfSYHCU=;
 b=x2NRlStNswEshSY2J9RqCU11LKPXY+liIIl9cDOEvLaLo38zW8UJ3kenYZ+xEfdR0m
 p+89BEVqqqTT3xE5HKVAcjNNK7yxor8Y4MeU2z/euzpRpo11D+77GF8ExxUr1gyWkM0q
 eRYVS00o7sJTIWDunxjOgeJzh5eB3l6y25DQxqGHta0bC7bqidr7pCZqTfAsEvhisS/H
 Hev8lqE0+JrFflaEh34AytyMWJ6LY5yB872TzWJuUeQeEwk3h/JOiYsrh2oqd7pQ8stV
 OR6MSrKSA+tGtTKBuMQssOEb9XrqtzA35vvDBEIgZupUOMvGXhCbYdWSnPw/tZTNRecD
 SN+g==
MIME-Version: 1.0
Received: by 10.68.218.226 with SMTP id pj2mr41853358pbc.33.1350343581425;
 Mon, 15 Oct 2012 16:26:21 -0700 (PDT)
Sender: adrian.chadd@gmail.com
Received: by 10.68.146.233 with HTTP; Mon, 15 Oct 2012 16:26:21 -0700 (PDT)
In-Reply-To: <CAF6rxgn9DcwqnZW4uwS8OLmKMbs3Fg9x8o50KWzDunLS_H-tDA@mail.gmail.com>
References: <201210150821.q9F8Lobc047576@svn.freebsd.org>
 <CAJ-VmomRx_n6LoXeQCPAX-KzVYqPcjhZt1J0MX89FiEEojPePw@mail.gmail.com>
 <CAF6rxgn9DcwqnZW4uwS8OLmKMbs3Fg9x8o50KWzDunLS_H-tDA@mail.gmail.com>
Date: Mon, 15 Oct 2012 16:26:21 -0700
X-Google-Sender-Auth: PUtSQsEPV6Gy37SGwnrIxcRck6Y
Message-ID: <CAJ-VmomTAPAOGjdJ8UZyY=mfnhbMAexyr_Fz9DMNqiyzDV0_fQ@mail.gmail.com>
Subject: Re: svn commit: r241576 - in head/usr.sbin/cron: cron crontab lib
From: Adrian Chadd <adrian@freebsd.org>
To: Eitan Adler <eadler@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: svn-src-head@freebsd.org, Maxim Sobolev <sobomax@freebsd.org>,
 svn-src-all@freebsd.org, src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Oct 2012 23:26:22 -0000

On 15 October 2012 16:10, Eitan Adler <eadler@freebsd.org> wrote:
> On 15 October 2012 18:45, Adrian Chadd <adrian@freebsd.org> wrote:
>> Why not sleep for the amonut of time needed before the next event?
>
> If the crontab changes in the meantime. If the next event is in a week,
> but you modify the crontab, you don't want to sleep until next event.

Right. So "check the crontab file" event is also an event with a
timestamp in the future.

Maybe crontab should be using a command via a socket to reload, rather
than stat'ing files..


Adrian


> Why we stat the file every quantum instead of using something kqueue is
> a different question.
>
>
> --
> Eitan Adler
> Source & Ports committer
> X11, Bugmeister, Ports Security teams