From owner-svn-src-head@freebsd.org Wed Dec 13 06:56:35 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 20393E934BB for ; Wed, 13 Dec 2017 06:56:35 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x235.google.com (mail-it0-x235.google.com [IPv6:2607:f8b0:4001:c0b::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D5E6C64B39 for ; Wed, 13 Dec 2017 06:56:34 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x235.google.com with SMTP id t1so2516896ite.5 for ; Tue, 12 Dec 2017 22:56:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=Rzemg23Q89dyLrBXF3q0+X2ppxAwHLeBsYy+ADKnRO0=; b=Ypijl/rSWaYyqhEs6Dm2R5RRljVH0W8aBIM0DxigS4K38fJEM2euxo/huuLndiSs2X KxVTInq+TOVl2MeCaV2YnqwwMOO+MSaCumrKFc86GfTrk4BopBMBiKLIhEV9cQVD3q5Q zBfPPjF54QxvWLJjtiUF2Kxegldu9/cjqmQ8cCiYTfIG1iTV6BKDxiZLvXwqx4g49NJH uSFTtrTEWw7bcvGS3k59R3v78NB7nAWBA2Z8Fbuq040wwn4S6io6Iu3X3OlopK7oqrtQ BcgxuT0que4jd9QTIehZ+HAX1n5it9sogJiwml9w9+ZPcx++SJJJGXexsvoLvqxkNXlz hzoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=Rzemg23Q89dyLrBXF3q0+X2ppxAwHLeBsYy+ADKnRO0=; b=pU43tC3cyqW5HS05nna3XJHoHLXKGTA+9/JpXUjF7bvoD96ZL5DN42oatYsahUKuTV bX2ZoFs/EFTLZ6QT5tDeCOG50DKDbLUYKn5hmizymdhujfS2fEVADdgXF4EdobOxDK5P r6Sc8FoQaD5MeR6vgvCdCsXREFIgnjT9I93puRfgzVrKiZeXvc6t79sGDWj9nW2oTehu b1hImk2VNU6VSNSsWEN10KEt6w4dl1s7Z8NJPdsEShiYMU5HvFMWkC3cX+LOrTbCrrCP 0tQXPc+6viad/axrbLZgZHogU0i/QQkbQcgeJL/fheYSlsrdKNxqWitMt6pCHMNfgWFQ dw7g== X-Gm-Message-State: AKGB3mIh6KW+wfJx9a+UiPt/gdSe9iR65AvYTDZtmfHR6+HvTm2EHOJV KSzr8xEGfyoDN4LQ0zqlE8kC5WTBFuhTvmfy6E+tCw== X-Google-Smtp-Source: ACJfBoviIArlRpylhDhB2f5Mg1y4DTN3kTjbGdEmV1FK+isnOASd/RRC4Abr3qcDr4N4XRUKWV14WceH8kgnRtpuoqM= X-Received: by 10.36.164.13 with SMTP id z13mr1791038ite.115.1513148194033; Tue, 12 Dec 2017 22:56:34 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.108.204 with HTTP; Tue, 12 Dec 2017 22:56:33 -0800 (PST) X-Originating-IP: [12.227.204.186] In-Reply-To: <20171213065443.GA31341@FreeBSD.org> References: <201712122022.vBCKM9Kd050769@repo.freebsd.org> <201712122039.vBCKdcV8088346@pdx.rh.CN85.dnsmgr.net> <20171213065443.GA31341@FreeBSD.org> From: Warner Losh Date: Wed, 13 Dec 2017 06:56:33 +0000 X-Google-Sender-Auth: ZqeFiHPIBHtH6QDVz1e7KIHwmNo Message-ID: Subject: Re: svn commit: r326809 - head/sys/dev/cardbus To: Alexey Dokuchaev Cc: "Rodney W. Grimes" , Warner Losh , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , src-committers Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Dec 2017 06:56:35 -0000 On Wed, Dec 13, 2017 at 6:54 AM, Alexey Dokuchaev wrote: > On Tue, Dec 12, 2017 at 12:39:38PM -0800, Rodney W. Grimes wrote: > > > New Revision: 326809 > > > URL: https://svnweb.freebsd.org/changeset/base/326809 > > > > > > Log: > > > 1k objects on the stack are a bad idea. While it's likely safe in > this > > > context, it's also safe to allocate the memory and free it instead. > > > > > > Noticed by: Eugene Grosbein's script > > > > YEA!!! One down, 20 to go and then see how the kstack issue does? > > > > And thank you for quickly fixing this. > > It's very promising to see debloat-type of work having started. On the > related note, what is current consensus with r326758, is it going to be > backed out and stack issues investigated and fixed? I am worried since > kib@ had mentioned that he's "almost sure that [32-bit x86 workstation] > users would get troubles now" [*] and I'm one of them. > I have fixes for 2 or 3 cam ones, and plans to fix another 3 or 4 of the remaining ones which are easy. Warner