From owner-freebsd-amd64@freebsd.org Tue Dec 6 16:39:21 2016 Return-Path: Delivered-To: freebsd-amd64@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4CBCCC6A41B for ; Tue, 6 Dec 2016 16:39:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3C6A11846 for ; Tue, 6 Dec 2016 16:39:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id uB6GdLPb077949 for ; Tue, 6 Dec 2016 16:39:21 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-amd64@FreeBSD.org Subject: [Bug 215101] [ixgbe] Intel X552 SFP+ fails to initialize when no SFP module is plugged in Date: Tue, 06 Dec 2016 16:39:21 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: mike@belopuhov.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter cc attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-amd64@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Porting FreeBSD to the AMD64 platform List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Dec 2016 16:39:21 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D215101 Bug ID: 215101 Summary: [ixgbe] Intel X552 SFP+ fails to initialize when no SFP module is plugged in Product: Base System Version: CURRENT Hardware: amd64 OS: Any Status: New Severity: Affects Many People Priority: --- Component: kern Assignee: freebsd-bugs@FreeBSD.org Reporter: mike@belopuhov.com CC: freebsd-amd64@FreeBSD.org CC: freebsd-amd64@FreeBSD.org Created attachment 177725 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D177725&action= =3Dedit Fix Due to the insufficient error handling Intel X552 SFP+ (8086:15ac) will fail to initialize on boot when no modules are plugged in and become completely unusable afterwards. I have discovered this bug on OpenBSD when updating our driver so there's a chance that this is not an issue on FreeBSD (I haven't tested), so you may consider this just a heads up. I'm attaching the fix that makes it operational on OpenBSD. This chunk is based on the similar one for 82599. Setting PHY type to "ixgbe_phy_none" will come in handy during "ifconfig up" since ixgbe_init[_locked] will re-do the PHY/SFP initialization if the PHY type has been previously set to "none". Cheers, Mike --=20 You are receiving this mail because: You are on the CC list for the bug.=