From owner-svn-src-head@FreeBSD.ORG Tue Jul 19 00:20:42 2011 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B81751065675; Tue, 19 Jul 2011 00:20:42 +0000 (UTC) (envelope-from marcel@xcllnt.net) Received: from mail.xcllnt.net (mail.xcllnt.net [70.36.220.4]) by mx1.freebsd.org (Postfix) with ESMTP id 8204A8FC20; Tue, 19 Jul 2011 00:20:42 +0000 (UTC) Received: from sa-nc-spg-102.static.jnpr.net (natint3.juniper.net [66.129.224.36]) (authenticated bits=0) by mail.xcllnt.net (8.14.5/8.14.5) with ESMTP id p6J0KZ6X087521 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Mon, 18 Jul 2011 17:20:41 -0700 (PDT) (envelope-from marcel@xcllnt.net) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Marcel Moolenaar In-Reply-To: <201107181519.p6IFJfOK028280@svn.freebsd.org> Date: Mon, 18 Jul 2011 17:20:29 -0700 Content-Transfer-Encoding: 7bit Message-Id: <208D139E-CDC3-428D-8D5F-F772BFAF164C@xcllnt.net> References: <201107181519.p6IFJfOK028280@svn.freebsd.org> To: Attilio Rao X-Mailer: Apple Mail (2.1084) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r224187 - in head: sys/amd64/amd64 sys/arm/arm sys/arm/sa11x0 sys/i386/i386 sys/ia64/ia64 sys/kern sys/mips/mips sys/powerpc/aim sys/powerpc/booke sys/sparc64/sparc64 sys/sys usr.bin/vm... X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jul 2011 00:20:42 -0000 On Jul 18, 2011, at 8:19 AM, Attilio Rao wrote: > Author: attilio > Date: Mon Jul 18 15:19:40 2011 > New Revision: 224187 > URL: http://svn.freebsd.org/changeset/base/224187 > > Log: > - Remove the eintrcnt/eintrnames usage and introduce the concept of > sintrcnt/sintrnames which are symbols containing the size of the 2 > tables. > - For amd64/i386 remove the storage of intr* stuff from assembly files. > This area can be widely improved by applying the same to other > architectures and likely finding an unified approach among them and > move the whole code to be MI. More work in this area is expected to > happen fairly soon. > > No MFC is previewed for this patch. You just broke ia64 and possibly other 64-bit architectures: ".word" declares a 16-bit integral on ia64 and the size symbols are of type size_t (=64 bit). We'll be having misaligned loads (= kernel panics) and/or reading garbage... Use "data8" on ia64, as per the assembly language reference. eris% cat x.s .data foo: .word 0x11223344 foo1: .byte 0x99 eris% as x.s -o x.o x.s: Assembler messages: x.s:3: Warning: value 0x11223344 truncated to 0x3344 eris% nm x.o 0000000000000000 d foo 0000000000000002 d foo1 FYI, -- Marcel Moolenaar marcel@xcllnt.net